On Sat, Oct 17, 2020 at 03:39:45PM -0400, Daniel Dickman wrote:
> pyrex was added as a BDEP for xmms2 in Makefile r1.3. My guess is that an
> earlier version of xmms2 may have needed it.
> This BDEP seems to have been cargo-culted forward over the years. Looking
> in INSTALL I see that cython is mentioned rather than pyrex. Presumably
> that means xmms2 had switched from pyrex -> cython by the time the ports
> tree got version 0.8 of xmms2 back in 2012.
> I confirmed xmms2 builds fine without pyrex.
> Looking in the Makefile I see do-configure: has the "--no-cython" option
> so don't seem to need to replace the pyrex BDEP with a cython BDEP.
> ok?
Works fine for me on amd64.
ok kmos
--Kurt
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/audio/xmms2/Makefile,v
> retrieving revision 1.53
> diff -u -p -u -r1.53 Makefile
> --- Makefile 24 Feb 2020 09:32:38 -0000 1.53
> +++ Makefile 17 Oct 2020 19:22:42 -0000
> @@ -5,7 +5,7 @@ COMMENT = audio player daemon with libr
> V = 0.8
> DISTNAME = xmms2-${V}DrO_o
> PKGNAME = xmms2-${V}
> -REVISION = 13
> +REVISION = 14
>
> SHARED_LIBS += xmmsclient++ 2.0 # 4.0.0
> SHARED_LIBS += xmmsclient++-glib 1.0 # 1.0.0
> @@ -36,8 +36,7 @@ MODULES = lang/python \
>
> NO_TEST = Yes
>
> -BUILD_DEPENDS = devel/pyrex \
> - devel/boost
> +BUILD_DEPENDS = devel/boost
>
> LIB_DEPENDS = devel/glib2 \
> databases/sqlite3 \
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/audio/xmms2/pkg/PLIST,v
> retrieving revision 1.7
> diff -u -p -u -r1.7 PLIST
> --- pkg/PLIST 18 Jul 2018 19:36:37 -0000 1.7
> +++ pkg/PLIST 17 Oct 2020 19:22:42 -0000
> @@ -97,43 +97,43 @@ lib/python${MODPY_VERSION}/site-packages
> lib/python${MODPY_VERSION}/site-packages/xmmsclient/propdict.py
> lib/python${MODPY_VERSION}/site-packages/xmmsclient/qt3.py
> lib/python${MODPY_VERSION}/site-packages/xmmsclient/sync.py
> -lib/python${MODPY_VERSION}/site-packages/xmmsclient/xmmsapi.so
> -lib/python${MODPY_VERSION}/site-packages/xmmsclient/xmmsvalue.so
> +@so lib/python${MODPY_VERSION}/site-packages/xmmsclient/xmmsapi.so
> +@so lib/python${MODPY_VERSION}/site-packages/xmmsclient/xmmsvalue.so
> lib/xmms2/
> -lib/xmms2/libxmms_ao.so
> -lib/xmms2/libxmms_apefile.so
> -lib/xmms2/libxmms_asf.so
> -lib/xmms2/libxmms_asx.so
> -lib/xmms2/libxmms_avcodec.so
> -lib/xmms2/libxmms_cue.so
> -lib/xmms2/libxmms_curl.so
> -lib/xmms2/libxmms_daap.so
> -lib/xmms2/libxmms_diskwrite.so
> -lib/xmms2/libxmms_equalizer.so
> -lib/xmms2/libxmms_file.so
> -lib/xmms2/libxmms_flac.so
> -lib/xmms2/libxmms_flv.so
> -lib/xmms2/libxmms_gvfs.so
> -lib/xmms2/libxmms_html.so
> -lib/xmms2/libxmms_icymetaint.so
> -lib/xmms2/libxmms_id3v2.so
> -lib/xmms2/libxmms_jack.so
> -lib/xmms2/libxmms_karaoke.so
> -lib/xmms2/libxmms_m3u.so
> -lib/xmms2/libxmms_mp4.so
> -lib/xmms2/libxmms_mpg123.so
> -lib/xmms2/libxmms_normalize.so
> -lib/xmms2/libxmms_null.so
> -lib/xmms2/libxmms_nulstripper.so
> -lib/xmms2/libxmms_pls.so
> -lib/xmms2/libxmms_replaygain.so
> -lib/xmms2/libxmms_rss.so
> -lib/xmms2/libxmms_sndfile.so
> -lib/xmms2/libxmms_tta.so
> -lib/xmms2/libxmms_vorbis.so
> -lib/xmms2/libxmms_wave.so
> -lib/xmms2/libxmms_xml.so
> -lib/xmms2/libxmms_xspf.so
> +@so lib/xmms2/libxmms_ao.so
> +@so lib/xmms2/libxmms_apefile.so
> +@so lib/xmms2/libxmms_asf.so
> +@so lib/xmms2/libxmms_asx.so
> +@so lib/xmms2/libxmms_avcodec.so
> +@so lib/xmms2/libxmms_cue.so
> +@so lib/xmms2/libxmms_curl.so
> +@so lib/xmms2/libxmms_daap.so
> +@so lib/xmms2/libxmms_diskwrite.so
> +@so lib/xmms2/libxmms_equalizer.so
> +@so lib/xmms2/libxmms_file.so
> +@so lib/xmms2/libxmms_flac.so
> +@so lib/xmms2/libxmms_flv.so
> +@so lib/xmms2/libxmms_gvfs.so
> +@so lib/xmms2/libxmms_html.so
> +@so lib/xmms2/libxmms_icymetaint.so
> +@so lib/xmms2/libxmms_id3v2.so
> +@so lib/xmms2/libxmms_jack.so
> +@so lib/xmms2/libxmms_karaoke.so
> +@so lib/xmms2/libxmms_m3u.so
> +@so lib/xmms2/libxmms_mp4.so
> +@so lib/xmms2/libxmms_mpg123.so
> +@so lib/xmms2/libxmms_normalize.so
> +@so lib/xmms2/libxmms_null.so
> +@so lib/xmms2/libxmms_nulstripper.so
> +@so lib/xmms2/libxmms_pls.so
> +@so lib/xmms2/libxmms_replaygain.so
> +@so lib/xmms2/libxmms_rss.so
> +@so lib/xmms2/libxmms_sndfile.so
> +@so lib/xmms2/libxmms_tta.so
> +@so lib/xmms2/libxmms_vorbis.so
> +@so lib/xmms2/libxmms_wave.so
> +@so lib/xmms2/libxmms_xml.so
> +@so lib/xmms2/libxmms_xspf.so
> ${P5ARCH}/
> ${P5ARCH}/Audio/
> ${P5ARCH}/Audio/XMMSClient/
> @@ -148,7 +148,7 @@ ${P5ARCH}/Audio/XMMSClient/Sync.pm
> ${P5ARCH}/auto/
> ${P5ARCH}/auto/Audio/
> ${P5ARCH}/auto/Audio/XMMSClient/
> -${P5ARCH}/auto/Audio/XMMSClient/XMMSClient.so
> +@so ${P5ARCH}/auto/Audio/XMMSClient/XMMSClient.so
> @man man/man1/xmms2-et.1
> @man man/man1/xmms2-launcher.1
> @man man/man1/xmms2-mdns-avahi.1
>
