On Sun, Oct 29, 2023 at 02:23:59PM +0100, Antoine Jacoutot wrote:
> Any reason we don’t want support for it ?
> I mean the whole point in hooking it up is to be able to use it, no?
in the Wayland case, libudev is used to enumerate input devices, which is
done inside libinput and/or Wayland compositors.
Other uses of libudev-openbsd as a replacement for libudev are
probably not usable currently, so ihmo it's not a good idea to allow
random ports to pick it up (especially if they also have alternative
ways to enumerate devices on OpenBSD).
>
> —
> Antoine
>
> > On 29 Oct 2023, at 13:46, Matthieu Herrb <matth...@herrb.eu> wrote:
> >
> > On Sun, Oct 29, 2023 at 11:35:43AM +0100, Antoine Jacoutot wrote:
> >>> On Sun, Oct 29, 2023 at 04:21:01AM -0600, Rafael Sadowski wrote:
> >>> CVSROOT: /cvs
> >>> Module name: ports
> >>> Changes by: rsadow...@cvs.openbsd.org 2023/10/29 04:21:01
> >>>
> >>> Modified files:
> >>> wayland : Makefile
> >>>
> >>> Log message:
> >>> Hook up wayland/xwayland and wayland/libinput-openbsd
> >>>
> >>> OK matthieu@
> >>
> >> This requires sysutils/libudev-openbsd which is NOT hooked up.
> >> There might have been a good reason for it, robert?
> >>
> >
> > There is also a multimedia/libv4l patch that is needed if
> > libudev-openbsd gets hooked to the build. iirc I never got an ok for
> > it.
> >
> > Here is a rebased version :
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /local/cvs/ports/multimedia/libv4l/Makefile,v
> > retrieving revision 1.32
> > diff -u -p -u -r1.32 Makefile
> > --- Makefile 27 Oct 2023 15:23:45 -0000 1.32
> > +++ Makefile 29 Oct 2023 12:43:32 -0000
> > @@ -3,7 +3,7 @@ COMMENT = libv4l userspace library
> > VERSION = 1.20.0
> > DISTNAME = v4l-utils-${VERSION}
> > PKGNAME = libv4l-${VERSION}
> > -REVISION = 4
> > +REVISION = 5
> >
> > SHARED_LIBS += v4l1 0.0 # 0.0
> > SHARED_LIBS += v4l2 0.0 # 0.0
> > Index: patches/patch-configure_ac
> > ===================================================================
> > RCS file: patches/patch-configure_ac
> > diff -N patches/patch-configure_ac
> > --- /dev/null 1 Jan 1970 00:00:00 -0000
> > +++ patches/patch-configure_ac 29 Oct 2023 12:43:32 -0000
> > @@ -0,0 +1,16 @@
> > +Ignore libudev-openbsd if present
> > +
> > +Index: configure.ac
> > +--- configure.ac.orig
> > ++++ configure.ac
> > +@@ -291,8 +291,8 @@ else
> > + AC_MSG_WARN(ALSA library not available)
> > + fi
> > +
> > +-PKG_CHECK_MODULES(libudev, libudev, have_libudev=yes, have_libudev=no)
> > +-if test "x$have_libudev" = "xyes"; then
> > ++# PKG_CHECK_MODULES(libudev, libudev, have_libudev=yes, have_libudev=no)
> > ++if /bin/false; then
> > + AC_DEFINE([HAVE_LIBUDEV], [], [Use libudev])
> > + LIBUDEV_CFLAGS="$libudev_CFLAGS"
> > + LIBUDEV_LIBS="$libudev_LIBS"
> > --
> > Matthieu Herrb
>
--
Matthieu Herrb
