CVSROOT: /cvs
Module name: ports
Changes by: [email protected] 2025/06/19 08:27:07
Modified files:
security/openssl/3.3: Makefile
security/openssl/3.4: Makefile
security/openssl/3.5: Makefile
Log message:
Disable no-thread config option on OpenSSL
This is a holdover from the initial port of OpenSSL 1.0.1h which fabien
found to be the culprit blocking progress on some node madness. This
is a tweaked version from a patch initially provided by fabien and then
volker. No concerns raised on ports@.
In addition to adding a missing pthread in WANTLIB compared to the initial
diff, switch sparc64 to ports-gcc, which provides the proper C11 atomics,
lacking in base-gcc 4.2.1. This avoids completely broken fallback code in
OpenSSL in at least their 3.3 and 3.4 branches that would require an insane
patch fest to work around problems from a PR that was not only poorly
written, tested and reviewed as per usual, but actually did not even
compile. Fortunately - otherwise our poor sparc64 OpenSSL users would run
a version of that crap now. For one thing the diff in question added a
wonderful and unused IMPL_fallback_atomic_compare_exchange_n() with
completely bogus arguments and chose to call the already existing
IMPL_fallback_atomic_exchange_n() instead but that's far from the only two
glaring problems in these 23 lines added.
Follow the bread crumbs in https://github.com/openssl/openssl/issues/26740
if you really must know more. A quick glance at the vertically aligned
backslashes should already set off all alarm sirens of the greenest of
all green reviewers.
