On Thu, Sep 07, 2017 at 09:21:27AM -0600, Robert Nagy wrote:
> CVSROOT:      /cvs
> Module name:  ports
> Changes by:   rob...@cvs.openbsd.org  2017/09/07 09:21:27
> 
> Log message:
>     import of the inteldrm port for creating the firmware package that 
> includes
>     firmwares for i915/inteldrm
>     
>     ok ajacoutot@

This does not package the correct guc files.

The code in tree has:
intel_guc_loader.c:#define I915_SKL_GUC_UCODE "i915/skl_guc_ver4.bin"

proposed kaby lake patch has

#define I915_KBL_GUC_UCODE "i915/kbl_guc_ver9_14.bin"

but only i915/skl_guc_ver6.bin is packaged.

Naming the files i915-filename or inteldrm-filename without a
.ucode/.bin suffix instead of putting them in a i915 directory would be
consistent with how the other firmware is handled.

>     
>     Status:
>     
>     Vendor Tag:       robert
>     Release Tags:     robert_20170907
>     
>     N ports/sysutils/firmware/inteldrm/Makefile
>     N ports/sysutils/firmware/inteldrm/distinfo
>     N ports/sysutils/firmware/inteldrm/pkg/DESCR
>     N ports/sysutils/firmware/inteldrm/pkg/PLIST
>     
>     No conflicts created by this import
> 

Reply via email to