On Thu, Feb 15, 2018 at 08:30:08AM +0000, Gonzalo L. Rodriguez wrote:
> CVSROOT:      /cvs
> Module name:  ports
> Changes by:   gonz...@cvs.openbsd.org 2018/02/15 01:30:08
> 
> Log message:
>     high performance network IDS, IPS and security monitoring OK jasper@
>     
>     Status:
>     
>     Vendor Tag:       gonzalo
>     Release Tags:     gonzalo_20181502
>     
>     N ports/security/suricata/Makefile
>     N ports/security/suricata/distinfo
>     N ports/security/suricata/pkg/DESCR
>     N ports/security/suricata/pkg/PLIST
>     N ports/security/suricata/pkg/suricata.rc
>     N ports/security/suricata/pkg/README
>     N ports/security/suricata/patches/patch-suricata_yaml_in
>     
>     No conflicts created by this import

Hi.

That line in the rc.d script looks bogus, why is it needed?:
daemon_flags=""

I also don't understand the need for a specific rc_start() function.

You need to reset @owner and @group before the @rcscript marker in your PLIST.
Otherwise it will have wrong permissions.

In CONFIGURE_ENV you have:
CPPFLAGS="${CPPFLAGS} -I${LOCALBASE}/include"
LDFLAGS="${LDFLAGS} -L${LOCALBASE}/lib"
Is it necessary to have ${CPPFLAGS} and ${LDFLAGS} since they aren't defined
elsewhere?

-- 
Antoine

Reply via email to