On Sun, Jan 06, 2019 at 11:06:27PM +0100, Antoine Jacoutot wrote: > On Sun, Jan 06, 2019 at 09:49:00PM +0000, Stuart Henderson wrote: > > On 2019/01/06 22:27, Antoine Jacoutot wrote: > > > On Sun, Jan 06, 2019 at 08:45:00PM +0000, Stuart Henderson wrote: > > > > On 2019/01/06 21:28, Antoine Jacoutot wrote: > > > > > On Sun, Jan 06, 2019 at 01:15:51PM -0700, Landry Breuil wrote: > > > > > > CVSROOT: /cvs > > > > > > Module name: ports > > > > > > Changes by: lan...@cvs.openbsd.org 2019/01/06 13:15:51 > > > > > > > > > > > > Modified files: > > > > > > audio/ncmpc : Makefile > > > > > > > > > > > > Log message: > > > > > > Pass -Db_asneeded=false to meson so that it doesn't add > > > > > > -Wl,--as-needed. > > > > > > > > > > > > Fixes the build on i386/ld.bfd archs which was failing with missing > > > > > > refs > > > > > > to pthread functions, as reported by sthen@ > > > > > > > > > > Why not contain this to ld.bfd archs then? > > > > > > > > Makes sense, but also why constrain it to ncmpc? meson itself seems > > > > the obvious place, here's one way to do it (using patch+sed to avoid > > > > a conditional patch file because I know what fun port updates are > > > > when you use them :) > > > > > > > > As a bonus this fixes gvfs. > > > > > > I like this better. > > > *But*, can't it have an effect on WANTLIB? > > > > Ugh, yes. > > > > gvfs-1.38.1(x11/gnome/gvfs,-main): > > Missing: gck-1.2 from gcr-3.28.0p3 (/usr/local/lib/gvfs/libgvfsdaemon.so) > > Missing: gpg-error.3 from libgpg-error-1.33 > > (/usr/local/libexec/gvfsd-afp-browse) > > Missing: p11-kit.2 from p11-kit-0.23.2p1 > > (/usr/local/lib/gvfs/libgvfsdaemon.so) > > Missing: pthread.25 (/usr/local/libexec/gvfsd-dnssd) (system lib) > > WANTLIB += gck-1 gpg-error p11-kit pthread > > Scanning: ok > > > > I don't see what we can really do about it though. At least they would > > have a path via LIB_DEPENDS already so it shouldn't result in completely > > missing dependencies, and if I understand as-needed correctly then e.g. > > in the case of say gvfs and p11-kit, it shouldn't be gvfs directly > > depending on p11-kit's ABI but rather gvfs depends on $some_other_port's > > ABI, and it's only $some_other_port that needs updating if p11-kit changes.. > > So I don't think this would cause a real problem. But it is messy, > > especially if someone does a WANTLIB sweep across the tree on i386 :/ > > Indeed, not a real problem, but messy :-/
Well it *is* a problem. I often do port-lib-depends-check on amd64 and/or i386, without really checking on which arch i am, and fix WANTLIB accordingly. Now if all meson ports have a different WANTLIB between ld.lld and ld.bfd archs, it is imo an issue. If we decide from now on that 'WANTLIB should be correct on amd64 and we dont care about others' it has to be clearly marked somewhere as a policy... Why not disabling --as-needed for all archs ? I've often had funny issues with it. Landry
