arrowd added inline comments.

INLINE COMMENTS

> Makefile:6
> +DISTNAME=    MoonlightSrc-${DISTVERSIONFULL}
> +EXTRACT_SUFX=        .tar.gz
> +MASTER_SITES=        
> https://github.com/moonlight-stream/moonlight-qt/releases/download/v${DISTVERSION}/

This is default, no need to set it explicitly.

> Makefile:24
> +USES=                qmake:outsource
> +USES+=               qt:5 gl localbase:ldflags pkgconfig ssl xorg sdl
> +USE_QT=              core gui network quickcontrols2 svg declarative widgets 
> buildtools:build

Just use a single `USES=` for all values.

> Makefile:25
> +USES+=               qt:5 gl localbase:ldflags pkgconfig ssl xorg sdl
> +USE_QT=              core gui network quickcontrols2 svg declarative widgets 
> buildtools:build
> +USE_GL=              egl

Sort values alphabetically, but keep `:build` items at the end.

REPOSITORY
  R11 FreeBSD ports repository

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D42323/new/

REVISION DETAIL
  https://reviews.freebsd.org/D42323

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: lisp_25689_163.com, #games, fuz
Cc: arrowd, eduardo, freebsd-ports-list

Reply via email to