John Schneider <john.a.schneider_at_gmail.com> wrote on
Date: Sat, 14 Sep 2024 17:52:24 UTC 

> Hi Kevin,
> 
> Can you or anyone else please comment on the official package builders
> poudriere.conf setting for MAX_FILES_vscode ? Just want to confirm why the
> build was successful last Thursday.

The modern poudriere-devel installation puts in a
/usr/local/etc/poudriere.conf* that has:

QUOTE
# How many file descriptors to limit each jail process to (default: 8192)
# This can also be set per PKGBASE, such as MAX_FILES_RStudio=2048.
# Package names with hyphens (-) should be replaced with underscores (_).
#MAX_FILES=8192
END QUOTE

(Just looked at my environment to get started.)

This suggests the following investigation . . .

That was committed to poudriere.conf.sample upstream on 2023-Mar-27 :

https://github.com/freebsd/poudriere/commit/9ea59e59f12f2b77699de9cafa5ceea1f7814eaf

ports-mgmt/poudriere started using 3.4.* at:

QUOTE
author Baptiste Daroussin <b...@freebsd.org> 2023-12-11 08:54:28 +0000
committer Baptiste Daroussin <b...@freebsd.org> 2023-12-11 08:56:26 +0000
commit 5c3bc831b2562c080c177076e089156a37f87e31 (patch)
tree 13b2cef326087d84f2ea010040651ef78dbd2a5c /ports-mgmt/poudriere/Makefile
parent 90af7f14c31aac1cc077d982b1a54972602ae2f6 (diff)
download ports-5c3bc831b2562c080c177076e089156a37f87e31.tar.gz
ports-5c3bc831b2562c080c177076e089156a37f87e31.zip

ports-mgmt/poudriere: update to 3.4.0
END QUOTE

It is also part of 3.4.1 and 3.4.2 .

The upstream commit involved (dag-erling committed on Mar 27, 2023)
is described by:

QUOTE
Bump default MAX_FILES to 8192.

This is necessary to build some large ports, e.g. www/qt5-webengine which since 
5.15.8 fails at the linking stage with the current limit of 1024.
END QUOTE

poudriere 3.4.0+ has been in use for official package builds
since back on 2023-Dec-19 or so:

QUOTE (from a 140amd64-quarterly-job-01 build)
=>> Building ports-mgmt/pkg
build started at Tue Dec 19 01:11:57 UTC 2023
port directory: /usr/ports/ports-mgmt/pkg
package name: pkg-1.20.9
building for: FreeBSD 140amd64-quarterly-job-01 14.0-RELEASE-p3 FreeBSD 
14.0-RELEASE-p3 amd64
maintained by: p...@freebsd.org
Makefile datestamp: -rw-r--r-- 1 root wheel 2318 Dec 10 01:02 
/usr/ports/ports-mgmt/pkg/Makefile
Ports top last git commit: e563efafb
Ports top unclean checkout: no
Port dir last git commit: 9d52f5ae6
Port dir unclean checkout: no
Poudriere version: poudriere-git-3.4.0
Host OSVERSION: 1500006
Jail OSVERSION: 1400097
Job Id: 01
END QUOTE





Looking at old fallout information:

NOTE: if vscode was skipped because a prerequsite was not available,
then vscode does not show up in a fallout report.

I do not report "exp" builds below, just package builds.

2024-May:

[package - 140amd64-default][editors/vscode] Failed for vscode-1.89.0 in 
build/runaway pkg-fallout_at_FreeBSD.org

for which:

[10:27:38] Starting compilation...
=>> Killing runaway build after 7200 seconds with no output

[package - 140amd64-default][editors/vscode] Failed for vscode-1.89.1 in 
build/runaway pkg-fallout_at_FreeBSD.org

for which:

[20:19:46] Starting compilation...
=>> Killing runaway build after 7200 seconds with no output


Those are the only two package fallout reports after
2023-Dec-15 or so. All other lack of being built examples
were apparently from being skipped or ignored instead of
from a failed build.

Examples include:
(just one non-electron* Reason example)

http://beefy18.nyi.freebsd.org/build.html?mastername=main-amd64-default&build=p2577ea660d37_s82bebc79365

#       Package                 Origin          Reason
8       vscode-1.86.0           editors/vscode  electron27-27.3.1

http://beefy18.nyi.freebsd.org/build.html?mastername=main-amd64-default&build=pe9c9c73181b5_sbd45bbe440f

4       vscode-1.86.1           editors/vscode  electron27-27.3.2

http://beefy18.nyi.freebsd.org/build.html?mastername=main-amd64-default&build=pd5512ae7b8c6_s4517b7a2d54

8       vscode-1.87.1_1         editors/vscode  electron27-27.3.6

http://beefy18.nyi.freebsd.org/build.html?mastername=main-amd64-default&build=p2b1d5eb07273_s619e6f1f928

9       vscode-1.87.2           editors/vscode  electron27-27.3.7

http://beefy18.nyi.freebsd.org/build.html?mastername=main-amd64-default&build=pb7573d3199cc_sfb8a8333b48

8       vscode-1.87.2_2         editors/vscode  electron27-27.3.9

http://beefy18.nyi.freebsd.org/build.html?mastername=main-amd64-default&build=p760621ead617_s08b45203383

11      vscode-1.88.1_1         editors/vscode  electron28-28.3.1

http://beefy18.nyi.freebsd.org/build.html?mastername=main-amd64-default&build=p98ebc5d3c875_s3dc2a884898

212     vscode-1.89.1_1         editors/vscode  mesa-dri-24.0.8




I'll note that the build logs still have old warning messages
that are output despite the change in the MAX_FILES default . . .

From example official vscode build log files, such as:

https://pkg-status.freebsd.org/beefy22/data/140amd64-default/02faf78f4c9b/logs/vscode-1.89.1_1.log
(build started at Fri May 31 01:19:11 UTC 2024)

QUOTE
. . .
Poudriere version: poudriere-git-3.4.1-30-g79e3edcd
. . .
=======================<phase: check-sanity >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0

The limit imposed by poudriere(8) for the maximum number of files allowed to be
opened by a jail (default 1024) is exceeded during the build of vscode.
To successfully build vscode with poudriere(8), you must add the following
line to poudriere.conf:
MAX_FILES_vscode=8192
. . .
=======================<phase: fetch >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0

The limit imposed by poudriere(8) for the maximum number of files allowed to be
opened by a jail (default 1024) is exceeded during the build of vscode.
To successfully build vscode with poudriere(8), you must add the following
line to poudriere.conf:
MAX_FILES_vscode=8192
. . .
=======================<phase: checksum >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0

The limit imposed by poudriere(8) for the maximum number of files allowed to be
opened by a jail (default 1024) is exceeded during the build of vscode.
To successfully build vscode with poudriere(8), you must add the following
line to poudriere.conf:
MAX_FILES_vscode=8192
. . .
=======================<phase: extract >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0

The limit imposed by poudriere(8) for the maximum number of files allowed to be
opened by a jail (default 1024) is exceeded during the build of vscode.
To successfully build vscode with poudriere(8), you must add the following
line to poudriere.conf:
MAX_FILES_vscode=8192
. . .
END QUOTE


===
Mark Millard
marklmi at yahoo.com


Reply via email to