steven mestdagh <[EMAIL PROTECTED]> wrote:

> Yes, I tested sparc64 and i386, didn't spot any problems with it, but I
> don't use this program. Can someone ok this diff?

Basically looks OK.

But please take a look at this:

if cc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -I../../intl
-I/usr/local/include -pthread -I/usr/local/include/gtk-2.0
[...]
-DGTK_IS_2_2 -DGTK_ATLEAST_2_4 -DGTK_ATLEAST_2_6 -O6 -Wformat -Wbounded
-MT cr-statement.o -MD -MP -MF ".deps/cr-statement.Tpo" -c -o
cr-statement.o cr-statement.c;  then mv -f ".deps/cr-statement.Tpo"
".deps/cr-statement.Po"; else rm -f ".deps/cr-statement.Tpo"; exit 1; fi
[...]

See?  cssed is including its own libintl headers -- -I../../intl.  Does
it make sense?  Not for me.

Och, and don't forget to include attached patch.

Alek
-- 
It devoured my paper, it was a really good paper.
 -- Ellen Feiss, http://www.apple.com/switch/stories/ellenfeiss.html
$OpenBSD$
--- libcroco/parser/cr-om-parser.c.orig Fri Nov 25 11:11:15 2005
+++ libcroco/parser/cr-om-parser.c      Fri Nov 25 11:15:54 2005
@@ -1006,7 +1006,7 @@ cr_om_parser_parse_paths_to_cascade (CRO
 
         g_return_val_if_fail (a_this, CR_BAD_PARAM_ERROR);
 
-        memset (sheets, 0, sizeof (CRStyleSheet) * 3);
+        memset (sheets, 0, sizeof (sheets));
         paths[0] = (guchar *) a_author_path;
         paths[1] = (guchar *) a_user_path;
         paths[2] = (guchar *) a_ua_path;

Reply via email to