Alexey E. Suslikov <[EMAIL PROTECTED]> wrote:

> Sredird is a serial port redirector that is compliant with the RFC 2217
> "Telnet Com Port Control Option" protocol. This protocol lets you share
> a serial port through the network.

Basically your port looks OK to me.  You missed some important stuff,
though.  Please consider applying following diff.  Also, I think that
you should add short blurb that describes what to do after installing
sredird, ie. add to pkg/MESSAGE or pkg/DESCR information from section
"5 - Installation" of README file that comes with sredird distfile.

Alek

diff -urN sredird.orig/Makefile sredird/Makefile
--- sredird.orig/Makefile       Sun Jun 18 01:59:45 2006
+++ sredird/Makefile    Sun Jun 18 02:09:41 2006
@@ -1,22 +1,25 @@
+# $OpenBSD$
+
 COMMENT=       "RFC 2217 compliant Telnet serial port redirector"
 
 DISTNAME=      sredird-2.2.2
-PKGNAME=       ${DISTNAME}
 CATEGORIES=    net comms
 
 MASTER_SITES=  http://www.ibiblio.org/pub/Linux/system/serial/
 
+# GPL
 PERMIT_PACKAGE_CDROM=  Yes
 PERMIT_PACKAGE_FTP=    Yes
 PERMIT_DISTFILES_CDROM=        Yes
 PERMIT_DISTFILES_FTP=  Yes
+WANTLIB=               c
 
-do-build:
+NO_REGRESS=    Yes
 
+do-build:
        ${CC} ${CFLAGS} -Wall -o ${WRKSRC}/sredird ${WRKSRC}/sredird.c
 
 do-install:
-
        ${INSTALL_PROGRAM} ${WRKSRC}/sredird ${PREFIX}/libexec
        ${INSTALL_MAN} ${WRKSRC}/sredird.8 ${PREFIX}/man/man8
 
diff -urN sredird.orig/patches/patch-sredird_c sredird/patches/patch-sredird_c
--- sredird.orig/patches/patch-sredird_c        Sun Jun 18 01:59:45 2006
+++ sredird/patches/patch-sredird_c     Sun Jun 18 02:10:18 2006
@@ -1,5 +1,6 @@
---- sredird.c.orig     Fri Mar  3 17:12:46 2006
-+++ sredird.c  Fri Mar  3 17:21:34 2006
+$OpenBSD$
+--- sredird.c.orig     Fri Aug 12 16:10:46 2005
++++ sredird.c  Sun Jun 18 02:10:10 2006
 @@ -110,9 +110,9 @@
  #include <fcntl.h>
  #include <syslog.h>
@@ -11,7 +12,7 @@
  #include <netinet/ip.h>
  #include <netinet/tcp.h>
  
-@@ -714,8 +717,6 @@
+@@ -714,8 +714,6 @@ unsigned long int GetPortSpeed(int PortF
                                        return(115200UL);
                                case B230400:
                                        return(230400UL);
@@ -20,7 +21,7 @@
                                default:
                                        return(0UL);
                        }
-@@ -1094,9 +1095,6 @@
+@@ -1094,9 +1092,6 @@ void SetPortSpeed(int PortFd, unsigned l
                                case 230400UL:
                                        Speed = B230400;
                                break;
@@ -30,7 +31,7 @@
                                default:
                                        LogMsg(LOG_WARNING,"Unknwon baud rate 
requested, setting to 9600.");
                                        Speed = B9600;
-@@ -2024,10 +2022,10 @@
+@@ -2024,10 +2019,10 @@ int main(int argc, char * argv[])
                 */
                SockParm = IPTOS_LOWDELAY;
                
setsockopt(STDIN_FILENO,SOL_SOCKET,SO_KEEPALIVE,&SockParmEnable,sizeof(SockParmEnable));
diff -urN sredird.orig/pkg/PLIST sredird/pkg/PLIST
--- sredird.orig/pkg/PLIST      Sun Jun 18 01:59:45 2006
+++ sredird/pkg/PLIST   Sun Jun 18 02:04:02 2006
@@ -1,2 +1,3 @@
[EMAIL PROTECTED] $OpenBSD$
 libexec/sredird
-man/man8/sredird.8
[EMAIL PROTECTED] man/man8/sredird.8

Reply via email to