Updated version attaached: - whitespace fixes
- while you had MODPY_SETUPTOOLS set you were overriding do-install so it didn't actually use the things setuptools did. change that to actually use setuptools, which sets #! lines etc for you and generates egg-info files, get rid of the patch / MODPY_ADJ_FILES - set MODPY_EGG_VERSION should be the string in the site-packages egg-info lines i.e. they should look like autorandr-${MODPY_EGG_VERSION}-py - i think x11 probably is better than sysutils though i am not wedded to that On 2020/11/03 14:04, Ashton Fagg wrote: > Finally getting back to this, I have addressed the review comments from > Klemens below. > > Updated version of the port attached as tarball. > > Package builds correctly. I installed it on my machine and it seems to > be working as expected (talking to xrandr as it should) - I have only > tested this on amd64. Portcheck is again clean. > > Comments on what specifically changed since intial review below. Any > suggestions appreciated. > > Thanks again Klemens for the initial review. > > > Klemens Nanni <k...@openbsd.org> writes: > > >> --- /dev/null > >> +++ b/sysutils/autorandr/Makefile > >> @@ -0,0 +1,29 @@ > >> +# $OpenBSD: Makefile,v 1.13 2019/11/10 16:25:41 kmos Exp $ > >> + > >> +COMMENT= automates xrandr calls based on connect devices > >> + > >> +MODPY_EGG_VERSION= 1.10.1 > > You can merge that right into GH_TAGNAME. > > Done. > > >> +DISTNAME= autorandr-${MODPY_EGG_VERSION} > > GH_* sets DISTNAME and PKGNAME automatically so only set them manually > > when required (not here). > > Done. > > >> +CATEGORIES= sysutils > > "x11" could do as second category. > > Done. Maybe it's better as the primary category, on reflection? > > >> + > >> +GH_ACCOUNT=phillipberndt > >> +GH_PROJECT=autorandr > >> +GH_TAGNAME=${MODPY_EGG_VERSION} > >> + > >> +# GPLv3 > >> +PERMIT_PACKAGE= Yes > >> + > >> +MAINTAINER=Ashton Fagg <ash...@fagg.id.au> > >> + > >> +MODULES= lang/python > >> +MODPY_SETUPTOOLS = Yes > > New ports should be using Python 3, i.e. > > MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3} > > Addressed. I also changed the Makefile to use MODPY_ADJ_FILES, so I am > not sure if the Python shebang needs to patched now... > > (Sorry, I am new to this). > > >> --- /dev/null > >> +++ b/sysutils/autorandr/patches/patch-autorandr_py > >> @@ -0,0 +1,11 @@ > >> +$OpenBSD$ > >> + > >> +Index: autorandr.py > >> +--- autorandr.py.orig > >> ++++ autorandr.py > >> +@@ -1,4 +1,4 @@ > >> +-#!/usr/bin/env python > >> ++#!/usr/bin/env python2 > > Use MODPY_ADJ_FILES, see port-modules(5). > > Addressed, see above. > > >> --- /dev/null > >> +++ b/sysutils/autorandr/pkg/DESCR > >> @@ -0,0 +1 @@ > >> +Automates xrandr actions. > > This is not a description, even COMMENT contains more information. > > Please be more elaborate so that `pkg_info autorandr' will tell users > > what to expect from this package before they install it. > > I have elaborated more in the attached version.
autorandr.tgz
Description: application/tar-gz