On 2020/11/07 15:38, Jeremie Courreges-Anglas wrote: > On Sat, Nov 07 2020, Rafael Sadowski <raf...@sizeofvoid.org> wrote: > > Please find below a diff to update jsoncpp to the latest stable version > > on github. This version includes all patches and fixes some security > > related bugs. I removed the include path patches. > > While I've cared about jsoncpp in the past I don't understand how its > headers could clash with something else (the patch mentions libc++ > headers). That's the whole point of using an include/json/ subdirectory > and telling people to use <json/foo> in their code. Maybe some people > missed the point and started including just <foo> and > add -I/usr/local/include/json to their build system.
Only thing to be aware of is that some ports may start picking up jsoncpp (or may use the system version rather than a bundled one) as a result of this path change. Besides the ports where jsoncpp is a listed dependency, here are the others where it shows in build logs. Some of these are really a pain if they fail in bulk build so it would be nice if they could be checked to make sure they don't start picking it up. devel/electron games/odamex games/stepmania www/chromium www/firefox-esr www/iridium www/mozilla-firefox www/nginx www/ruby-passenger www/seamonkey www/tor-browser/browser x11/gnome/file-roller
