On Fri, 6 Nov 2020 19:21:27 -0500 (EST)
Daniel Dickman <didick...@gmail.com> wrote:
> This diff sets NO_TEST=Yes for cython under python2 so numpy can be
> updated.
>
> If we don't go this route, we'd have to convert all the cython
> consumers to python3 so cython can be made python3-only. That means
> updating consumers like py-sphinx. So going down that path doesn't
> look very simple.
>
> ok on the simpler approach below so we can move forward?
Sure, OK juanfra@.
Do you want to take the maintainership of cython?. You have been doing
the work for the last updates and looks like cython is the most
critical port in the dependency chain of some of your ports.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/lang/cython/Makefile,v
> retrieving revision 1.45
> diff -u -p -u -r1.45 Makefile
> --- Makefile 10 Oct 2020 18:31:55 -0000 1.45
> +++ Makefile 7 Nov 2020 00:14:48 -0000
> @@ -6,6 +6,7 @@ MODPY_EGG_VERSION = 0.29.21
> DISTNAME = Cython-${MODPY_EGG_VERSION}
> PKGNAME = py-cython-${MODPY_EGG_VERSION}
> CATEGORIES = lang
> +REVISION = 0
>
> HOMEPAGE = https://cython.org/
>
> @@ -17,13 +18,22 @@ PERMIT_PACKAGE = Yes
> WANTLIB += pthread ${MODPY_WANTLIB}
>
> MODULES = lang/python
> +
> +FLAVORS = python3
> +FLAVOR ?=
> +
> MODPY_PI = Yes
> MODPY_SETUPTOOLS = Yes
> +
> BUILD_DEPENDS = devel/py-setuptools_git${MODPY_FLAVOR}
> -TEST_DEPENDS = math/py-numpy${MODPY_FLAVOR}
>
> -FLAVORS = python3
> -FLAVOR ?=
> +# XXX: no tests under python2 so numpy can be updated.
> +# (numpy>=1.17.0 is python3-only)
> +.if ${FLAVOR:Mpython3}
> +TEST_DEPENDS += math/py-numpy${MODPY_FLAVOR}
> +.else
> +NO_TEST = Yes
> +.endif
>
> PORTHOME = ${WRKDIR}
>
--
Juan Francisco Cantero Hurtado http://juanfra.info
