On 2020/11/11 06:10, wen heping wrote:
> Hi, ports@:
> 
>     Here is a patch for graphics/img2pdf:
>      i) Update to 0.4.0
>      ii) Add py-pikepdf as RUND
>      iii) Remove py-Pillow from TEST_DEPENDS, since it is
> RUND and there is no test code upstream

There is test code but it wasn't run correctly. I have fixed that with
MODPY_PYTEST=Yes.

>      iv) Remove the comments about pdfrw, now it does
> not require pdfrw.

I have kept these. img2pdf didn't require pdfrw before, it was optional
(and still is) but still causes test failures if not present.

> 
>      It build well and run well on amd64-6.8 system, and no
> other ports depend on it.
> 
> 
> Cheers !
> wen

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/graphics/img2pdf/Makefile,v
> retrieving revision 1.14
> diff -u -p -r1.14 Makefile
> --- Makefile  6 Jul 2020 10:07:44 -0000       1.14
> +++ Makefile  11 Nov 2020 06:03:12 -0000
> @@ -2,7 +2,7 @@
>  
>  COMMENT =            losslessly convert images to PDF
>  
> -MODPY_EGG_VERSION =  0.3.6
> +MODPY_EGG_VERSION =  0.4.0
>  DISTNAME =           img2pdf-${MODPY_EGG_VERSION}
>  
>  CATEGORIES =         graphics
> @@ -17,9 +17,7 @@ MODPY_VERSION =             ${MODPY_DEFAULT_VERSION
>  MODPY_SETUPTOOLS =   Yes
>  MODPY_PI =           Yes
>  
> -# some tests fail as they require pdfrw (overall this is optional for
> -# img2pdf and autodetected at runtime; we don't have it in ports yet)
> -RUN_DEPENDS =                graphics/py-Pillow${MODPY_FLAVOR}
> -TEST_DEPENDS =               graphics/py-Pillow${MODPY_FLAVOR}
> +RUN_DEPENDS =                graphics/py-Pillow${MODPY_FLAVOR} \
> +                     print/py-pikepdf${MODPY_FLAVOR}
>  
>  .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/graphics/img2pdf/distinfo,v
> retrieving revision 1.6
> diff -u -p -r1.6 distinfo
> --- distinfo  6 Jul 2020 10:07:44 -0000       1.6
> +++ distinfo  11 Nov 2020 06:03:12 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (img2pdf-0.3.6.tar.gz) = jNVQmmC3X0RCuJe609WT4l69MUEF8wNKjxfe85akoPs=
> -SIZE (img2pdf-0.3.6.tar.gz) = 91006
> +SHA256 (img2pdf-0.4.0.tar.gz) = 6u5pCrhAPdGpy02xCv7kHdPmx+1jvazgKgEh+f6tsMk=
> +SIZE (img2pdf-0.4.0.tar.gz) = 107027

Reply via email to