On 2020/11/12 06:41, Rafael Sadowski wrote:
> On Fri Oct 23, 2020 at 09:10:49PM +0200, Rafael Sadowski wrote:
> > On Wed Sep 16, 2020 at 09:46:45PM +0100, Stuart Henderson wrote:
> > > On 2020/09/16 22:39, Rafael Sadowski wrote:
> > > > On Wed Sep 16, 2020 at 09:10:16PM +0100, Stuart Henderson wrote:
> > > > > >
> > > > > > Does anyone want to leave an OK?
> > > > >
> > > > > Surely the rabbit hole needs following otherwise the update breaks
> > > > > working functionality?
> > > >
> > > > No, that has never worked before. See:
> > > >
> > > > $ puddletag
> > > > puddletag Version: 1.2.0
> > > > Locale: en_US
> > > > Object::disconnect: Unexpected null parameter
> > > > Error loading quodlibetlib: No module named quodlibet.config
> > > >
> > > > This is about my initial DESCR upgrade:
> > > >
> > > > > > > > > +Doing web lookups
> > > > > > > > > +using Amazon (including cover art), Discogs (does cover art
> > > > > > > > > too!), FreeDB and
> > > > > > > > > +MusicBrainz is also supported.
> > > >
> > > > I took that out again, because it has never worked before.
> > >
> > > No idea about using it with quodlibet but it used to do ID-based
> > > tagging using chromaprint if you installed the relevant package.
> > > Not sure if that is still working with what's in-tree - I can't
> > > test now (I won't run X on my workstation until I have time to do an
> > > install on a separate HD to test with, the filesystem corruption
> > > from the hangs was getting too much).
> > >
> >
> > If you describe to me how I can test it, I can do it for you/us. For me
> > the updated version behaves like the in-tree version.
> >
> > Rafael
> >
>
> Friendly reminder.
pkg_add chromaprint puddletag
puddletag &
Windows / tick "Tag sources"
Open a dir containing an album
Select all files in the album
In the "Tag sources" window set source to AcoustID
Click the Search button
This works in 1.2.0, and fails like so in 2.0.1:
Traceback (most recent call last):
File
"/usr/local/lib/python3.8/site-packages/puddlestuff/tagsources/acoust_id.py",
line 108, in fingerprint_file
return acoustid._fingerprint_file_fpcalc(fn, 120)
File
"/usr/local/lib/python3.8/site-packages/puddlestuff/tagsources/_acoustid.py",
line 299, in _fingerprint_file_fpcalc
parts = line.split('=', 1)
TypeError: a bytes-like object is required, not 'str'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/puddlestuff/webdb.py", line 866,
in search
return tag_source_search(self.curSource, group, files)
File "/usr/local/lib/python3.8/site-packages/puddlestuff/webdb.py", line 557,
in tag_source_search
albums = ts.search(primary, group[primary])
File
"/usr/local/lib/python3.8/site-packages/puddlestuff/tagsources/acoust_id.py",
line 314, in search
data, fp = match("gT8GJxhO", fn.filepath, fp, dur)
File
"/usr/local/lib/python3.8/site-packages/puddlestuff/tagsources/acoust_id.py",
line 135, in match
dur, fp = fingerprint_file(path)
File
"/usr/local/lib/python3.8/site-packages/puddlestuff/tagsources/acoust_id.py",
line 110, in fingerprint_file
return acoustid._fingerprint_file_fpcalc(fn)
TypeError: _fingerprint_file_fpcalc() missing 1 required positional argument:
'maxlength'
