On 2020/11/15 18:02, Andrea Fleckenstein wrote: > > Daniel Dickman <didick...@gmail.com> writes: > > One small thing I noticed is that while you say that the port works with > > python 3.8, it looks like you did not actually make that change in the > > diff. Any reason not to include that change? > > I think it's used automatically because of MODPY_DEFAULT_VERSION_3. > Someone more knowlegdeable can probably correct me on that.
Previous diff didn't change that but the new one does. > Stuart Henderson <s...@spacehopper.org> writes: > > My standard method for generating cvs diffs: update the files in the > > port dir - if I have a copy that I've been working on in another > > directory I normally use "rsync -avC --delete" for this (the C flag > > skips CVS directories etc automatically), then "cvs add" / "cvs rm" as > > necessary then generate the diff with "cvs diff -uNp" to get a full diff > > with the additions/removals). > > Sorry, I was trying to use diff(1). thanks for walking me through this. I > hope I did it right. attaching the tar too. Great, yes the diff applies fine. Building it I had a problem with it trying to #include <execinfo.h> and not finding it. Fixed with the diff below, I just removed the #include - it doesn't actually use the backtrace functions on OpenBSD anyway - this was causing my build to fail repeatably. It does make me wonder why you didn't see it though. I also had a problem building it if pugixml is installed, I think this is a conflict between openimageio's own copy of pugixml and the standalone one. I'm building oiio with -DUSE_EXTERNAL_PUGIXML=ON to see if that helps (it will take a while to build..) - if not then next step is probably to try updating oiio. Index: patches/patch-source_blender_blenlib_intern_system_c =================================================================== RCS file: patches/patch-source_blender_blenlib_intern_system_c diff -N patches/patch-source_blender_blenlib_intern_system_c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ patches/patch-source_blender_blenlib_intern_system_c 16 Nov 2020 14:04:49 -0000 @@ -0,0 +1,13 @@ +$OpenBSD$ + +Index: source/blender/blenlib/intern/system.c +--- source/blender/blenlib/intern/system.c.orig ++++ source/blender/blenlib/intern/system.c +@@ -38,7 +38,6 @@ + # include <dbghelp.h> + # pragma warning(pop) + #else +-# include <execinfo.h> + # include <unistd.h> + #endif +
