On 11/22, Stuart Henderson wrote: > On 2020/11/22 16:45, Klemens Nanni wrote: > > On Sun, Nov 22, 2020 at 02:42:16AM +0300, Pavel Korovin wrote: > > > I'm looking for OKs to import this. > > `make test' works with two small warnings, "devel" should probably be > > the primary category instead of "sysutils". > > sysutils is more descriptive, seems absolutely fine to me really..
My main use of this port is Ansible vSphere automation playbooks where tags management is involved, vSphere Automation SDK is a requirement for this: https://docs.ansible.com/ansible/2.9/modules/vmware_tag_module.html#vmware-tag-module I think it fits better to sysutils. > > Where do those LOCAL_DEPS come from? How did yoy compile that list? > > I'd be helpful to provide a comment, otherwise it just looks odd. This port is tricky: it has dependencies bundled as Python wheel files. I came to the loop approach since these ${LOCAL_DEPS} must be installed in order because one depends on another and dependencies order is different from aphabetical. > maybe better to generate the list using "find ${WRKSRC}/lib -name *.whl" > in the command itself? it would be less to maintain in the port Makefile. I didn't take in mind that pip is smart enough to check the dependencies with the bulk install. Stuart, thanks for the tip! Fixed, Makefile looks much cleaner now. > > Please put all variables (TEST_ENV) above targets. Done. > > pre-build could `cd' into the dir and install all of ${LOCAL_DEPS} at > > once, avoiding the make loop. > > You set PYTHONPATH in pre-build and TEST_ENV, can those be merged into > > a common environment? Collapsed both into MAKE_ENV. > > > Description: > > > VMware vSphere Automation SDK for Python > > Please fill DESCR and do not duplicate COMMENT. > > > > This could be borrowed from "about" at the top right of > https://github.com/vmware/vsphere-automation-sdk-python : > > Python samples, language bindings, and API reference documentation for > vSphere, VMC, and NSX-T using the VMware REST API. Done. Corrected port is attached, thank you! -- With best regards, Pavel Korovin
py-vsphere-automation.tgz
Description: Binary data
