On 2021/01/15 14:02, Luca De Pandis wrote:
> Hi,
> could anyone review this, so that the port could be upgraded, please?
>
>
> Best regards,
> Luca De Pandis
>
>
> On Tue, Jan 12, 2021 at 10:40:00PM +0100, me wrote:
> > Hi,
> > I updated the lang/nim port to the latest version.
> >
> > The following checks passed:
> > - portcheck
> > - port-lib-depends-check
> > - update-plist
> >
> > Best regards,
> > Luca De Pandis
>
>
3 days is way too soon to be prodding really, especially for what is
a relatively specialist port that most ports devs won't use. Anyway a
few quick comments I am short on time - as mentioned by others please
send a diff not a tar for updates. Use cvs add / cvs rm if there are
any new/removed files and cvs diff -uNp.
patch-config_nim_cfg:
-cc = gcc
+cc = clang
The compiler should be passed from the port in CC not hardcoded.
PLIST: missing @sample for the new cfg file
Makefile: drop REVISION, maybe the --parallelBuild:1 should really
be ${MAKE_JOBS} instead of 1
