On Tue, Jan 19, 2021 at 11:37:17PM -0500, Daniel Dickman wrote:
> 
> 
> On Wed, 20 Jan 2021, wen heping wrote:
> 
> > Hi, ports@:
> > 
> >   Here is a patch for geo/pygeoapi:
> >     i) Update to 0.9.0
> 
> What's the benefit of the update? What changed?

sadly upstream doesnt really provide changelog/release notes.
there's https://github.com/geopython/pygeoapi/milestone/7?closed=1

> >     ii) Add 2 missing DEPENDS
> 
> If you can show me how to test this port, I can commit it with some 
> tweaks.

its an ogc api server (aka WFS3), with a sample config (there's one
provided in the port iirc) you can access it on localhost.

> Same issue as the other port where we're relying on implicit dateutils via 
> click, rather than making it an explicit depend. We should fix that.

https://github.com/geopython/pygeoapi/blame/master/requirements.txt
indeed lists rasterio, proj and dateutils.

> > there is no test defined and no other ports depends on it.
> 
> True, but the commented out TEST_DEPENDS looks wrong to me. I think it 
> should be
>     TEST_DEPENDS +=
> instead of
>     TEST_DEPENDS =
> 
> (if we ever get the tests going, the former will make sure pytest is 
> installed for the tests).
> 
> speaking of which, does pulling the distfile from github rather than pypi 
> let us run the tests?

Yes, but iirc the tarball is ways larger.

Landry

Reply via email to