On Tue, Jan 26, 2021 at 09:20:55AM +0100, Pierre-Emmanuel André wrote:
> On Mon, Jan 25, 2021 at 08:43:26PM -0500, Daniel Jakots wrote:
> > On Fri, 20 Nov 2020 17:06:13 -0800, Jeremy Evans <jer...@openbsd.org>
> > wrote:
> >
> > > Could we please have this tested in a bulk? Assuming there are no
> > > problems in a bulk, OKs?
> >
> > Thanks for the diff!
> > I updated my server to it. It works fine for me.
> >
> > There is:
> > /usr/ports/databases/postgresql$ make port-lib-depends-check
> >
> > postgresql-client-13.1(databases/postgresql,-main):
> > Extra: iconv.7 lzma.2
> >
> > postgresql-server-13.1(databases/postgresql,-server):
> > Extra: iconv.7 lzma.2
> >
> > postgresql-contrib-13.1(databases/postgresql,-contrib):
> > Extra: iconv.7 lzma.2
> >
> > postgresql-pg_upgrade-13.1(databases/postgresql,-pg_upgrade):
> > Extra: iconv.7 lzma.2
> >
> > postgresql-plpython-13.1(databases/postgresql,-plpython):
> > Missing: intl.7 from gettext-runtime-0.21p0
> > (/usr/local/lib/postgresql/plpython2.so) WANTLIB += intl
> > *** Error 1 in target 'port-lib-depends-check' (ignored)
> >
> >
> > I haven't checked if the current 12.5 does the same or not, and I'm too
> > lazy to move my ports tree back to it to check (when do we switch to
> > got(1)?? :P).
> >
> >
> > Also it seems the current maintainer is very busy/unresponsive so
> > maybe it would make sense if you took maintainership?
> >
> >
> > Cheers,
> > Daniel
>
>
>
> Hello,
>
> Sorry for the late answer. It took me a long time to upgrade my biggest
> system to pg13.
> The diff looks good for me but i have some random failures on regress tests.
> Sometimes on regproc or another times on prepared_xacts.
> You never saw that ?
>
Nevermind it was a local issue.
I made this small change to database/postgresql/Makefile to fix WANTLIB:
@@ -99,7 +98,7 @@ INSTALL_TARGET= install-world
LIB_DEPENDS-main= archivers/xz \
converters/libiconv \
textproc/libxml
-WANTLIB-main = ${WANTLIB} iconv lzma xml2
+WANTLIB-main = ${WANTLIB} xml2
LIB_DEPENDS-server= databases/postgresql=${VERSION} \
@@ -119,7 +118,7 @@ LIB_DEPENDS-pg_upgrade= databases/postgr
WANTLIB-pg_upgrade = ${WANTLIB-main} pq
LIB_DEPENDS-plpython= ${MODPY_LIB_DEPENDS}
-WANTLIB-plpython = c m pthread util \
+WANTLIB-plpython = c intl m pthread util \
${MODPY_WANTLIB}
RUN_DEPENDS-plpython= databases/postgresql,-server=${VERSION}
