Re: [patch] net/sniproxy unbreak and -fno-common fix

[Renaud Allard]

On 2/9/21 3:54 PM, Theo Buehler wrote:

On Tue, Feb 09, 2021 at 03:41:29PM +0100, Renaud Allard wrote:

On 2/9/21 3:26 PM, Theo Buehler wrote:

On Tue, Feb 09, 2021 at 03:19:00PM +0100, Renaud Allard wrote:

Hello,

It seems that I didn't test sniproxy deep enough after the patch removal for
STAILQ_*. There are core dumps with sniproxy without the patch.

I think this needs deeper investigation. Could you share a backtrace or
a reproducer for these crashes?

My bad, I tried to reproduce it and it seems there was a problem in my
CFLAGS which caused the issue.

So here is the patch only for the -fno-common

While your patch fixes the compilation, I'd suggest going with the usual
change, which is also the one upstream merged:

https://github.com/dlundquist/sniproxy/pull/349

I added a patch for a warning about an incorrect format string on top.

Are you ok with this?

It seems lighter indeed and merged, so I guess this is the best way.

I compiled and tested with your patch and it looks fine.

So, OK for me.

smime.p7s
Description: S/MIME Cryptographic Signature