On 2021/03/05 06:18, Bjorn Ketelaars wrote: > Diff below updates zstd to 1.4.9, which is a bugfix release. Changelog > can be found at [0]. > > Visibility of symbols in shared library has been fixed [1] resulting in > check_sym reporting removal of several symbols. The latter warrants a > major bump of SHARED_LIBS. > > Regression tests pass on amd64, and build tested consumers.
I think a minor bump for the added function would actually be enough, it doesn't seem likely that other software would be directly calling the internal functions which are now hidden (especially as deps built ok), but major bump doesn't hurt either. > Do we need to test this update in a bulk? If not, comments/OK? No need for that I think. OK > > [0] https://github.com/facebook/zstd/blob/v1.4.9/CHANGELOG > [1] > https://github.com/facebook/zstd/commit/821d9acd17f251a8ee548eadbc3c5bccdfca7691 > > > diff --git Makefile Makefile > index dd086cd73c5..2cf83bebb9b 100644 > --- Makefile > +++ Makefile > @@ -2,10 +2,10 @@ > > COMMENT = zstandard fast real-time compression algorithm > > -V = 1.4.8 > +V = 1.4.9 > DISTNAME = zstd-${V} > > -SHARED_LIBS = zstd 4.0 # 1.4.7 > +SHARED_LIBS = zstd 5.0 # 1.4.9 > > CATEGORIES = archivers > > diff --git distinfo distinfo > index 4ee8dd4cb1c..1560e8c4b44 100644 > --- distinfo > +++ distinfo > @@ -1,2 +1,2 @@ > -SHA256 (zstd-1.4.8.tar.gz) = MkeCl8oVACEQCNWWJ29TZ8VBmElc9nfpQ59HkaTGnyQ= > -SIZE (zstd-1.4.8.tar.gz) = 1803550 > +SHA256 (zstd-1.4.9.tar.gz) = Kax04Z6ihlkBc2GXYkDEtcXCTbO4kzhzGm/rl8A40pM= > +SIZE (zstd-1.4.9.tar.gz) = 1821109 > diff --git patches/patch-lib_Makefile patches/patch-lib_Makefile > index f95960697f1..e9190f82814 100644 > --- patches/patch-lib_Makefile > +++ patches/patch-lib_Makefile > @@ -25,7 +25,7 @@ Index: lib/Makefile > -Wredundant-decls -Wmissing-prototypes -Wc++-compat > CFLAGS += $(DEBUGFLAGS) $(MOREFLAGS) > FLAGS = $(CPPFLAGS) $(CFLAGS) > -@@ -427,8 +427,6 @@ install-shared: > +@@ -428,8 +428,6 @@ install-shared: > [ -e $(DESTDIR)$(LIBDIR) ] || $(INSTALL) -d -m 755 $(DESTDIR)$(LIBDIR)/ > @echo Installing shared library > $(INSTALL_PROGRAM) $(LIBZSTD) $(DESTDIR)$(LIBDIR) > diff --git patches/patch-programs_Makefile patches/patch-programs_Makefile > index 012a78ef64b..5c3c731488c 100644 > --- patches/patch-programs_Makefile > +++ patches/patch-programs_Makefile > @@ -12,5 +12,5 @@ Index: programs/Makefile > - -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings \ > + -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings \ > -Wredundant-decls -Wmissing-prototypes -Wc++-compat > - CFLAGS += $(DEBUGFLAGS) $(MOREFLAGS) > - FLAGS = $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) > + CFLAGS += $(DEBUGFLAGS) > + CPPFLAGS += $(MOREFLAGS) > diff --git patches/patch-tests_Makefile patches/patch-tests_Makefile > index b76add422ac..f00f0b5f39c 100644 > --- patches/patch-tests_Makefile > +++ patches/patch-tests_Makefile > @@ -12,5 +12,5 @@ Index: tests/Makefile > - -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings > \ > + -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings \ > -Wredundant-decls -Wmissing-prototypes > - CFLAGS += $(DEBUGFLAGS) $(MOREFLAGS) > - FLAGS = $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) > + CFLAGS += $(DEBUGFLAGS) > + CPPFLAGS += $(MOREFLAGS) >
