On 2021/03/16 19:56, Theo Buehler wrote:
> I think the diff from https://www.lua.org/bugs.html#5.2.2-1 was
> backported to the wrong function (to adjust_varargs() instead of
> luaD_precall(). Compare with https://github.com/redis/redis/pull/7733
> 
> While I did not manage to make the PoC crash on my machines, I'm pretty
> sure the diff used by Redis is correct. Lua 5.2 also applied the fix to
> luaD_precall(), not adjust_varargs().

Agreed. The patch in https://www.lua.org/bugs.html#5.2.2-1 applies to
5.2.2 and the lines around 324 are definitely in luaD_precall().
OK

(wow at the comments in ray-project ticket linked at the bottom of the
redis pull request...)

Reply via email to