On Mon, 29 Mar 2021 at 02:18, Chris Cappuccio <ch...@nmedia.net> wrote:
> Marc Espie [es...@nerim.net] wrote: > > I've looked a bit at this code. > > > > I'm on the fence between marking it as BROKEN and give Chris a chance to > > fix the code, or downright removing it. > > > > Specifically, it's currently broken thanks to recent changes to if.h, > > but the code warns all over the place. There seems to be a misconception > > that '\0' would be a NULL pointer (it's not, it's a character constant). > > > > Well it was to mark the end of arguments in constructed argument lists, > but maybe just NULL would be fine. > in commands.c changing line 454 and swapping '\0' to a NULL got rid of the complier warning for me changing 1676 and swapping '\0' to a NULL got rid of the complier warning for me Thanks Tom Smyth