On Sat, Apr 03, 2021 at 02:56:05PM +0200, Charlene Wendling wrote: > Hi, > > > http://build-failures.rhaalovely.net/sparc64/2021-03-31/x11/gtk+4.log > > I can reproduce that on macppc at home (the current bulk builds the > previous version). > > ld.bfd often does not like "-Wl,--as-needed". The below diff allows > gtk+4 to be built on macppc [0]. This version has never been built > on ld.bfd archs, so no revision bump is needed. > > OK ? > > Charlène.
OK > > > [0] https://bin.charlenew.xyz/gtk4.success.log > > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/x11/gtk+4/Makefile,v > retrieving revision 1.42 > diff -u -p -u -p -r1.42 Makefile > --- Makefile 31 Mar 2021 13:42:46 -0000 1.42 > +++ Makefile 3 Apr 2021 12:14:54 -0000 > @@ -118,6 +118,12 @@ CONFIGURE_ARGS += -Dmedia-ffmpeg=disable > CFLAGS += -Wno-error > .endif > > +# disable meson's default of using "-Wl,--as-needed" on ld.bfd arches; > +# build failures due to undefined references are often seen. > +.if !${PROPERTIES:Mlld} > +CONFIGURE_ARGS += -Db_asneeded=false > +.endif > + > pre-configure: > ${SUBST_CMD} ${WRKSRC}/modules/printbackends/meson.build > > > > > -- Antoine
