On 2021/04/05 19:56, Anindya Mukherjee wrote:
> Hi,
> 
> Qutebrowser has a bug on OpenBSD which causes the prefers-color-scheme
> setting to not work correctly (e.g., test sites show that it is not
> supported, etc.). The problem is a hard-coded library filename for
> libQt5WebEngineCore.so.5 in
> /usr/local/lib/python3.8/site-packages/qutebrowser/misc/elf.py. I worked
> with The-Compiler and a fix has been committed upstream:
> https://github.com/qutebrowser/qutebrowser/commit/eb6f1cf9898cb431af9d2812ec40f811e37f57f0
> Would it be possible to backport this into the current port? I have
> tested the patch on my system and it fixes the issue. To test, simply
> set colors.webpage.preferred_color_scheme = dark and load
> https://www.openbsd.org/faq/. It will be displayed using the light
> scheme without this fix, regardless of the above setting.
> 
> OTOH 2.2 is not too far off and updating to that won't need maintaining
> a patch. I'm not sure what is the best way to proceed.
> 
> Regards,
> Anindya
> 

The fix is not correct, it should not check for existence of the file, just
try to dlopen libQt5WebEngineCore.so (no version).

See dlopen(3) "When a shared library is specified without a version ..."

Reply via email to