Le Wed, May 19, 2021 at 05:12:27PM +0300, Kirill Bychkov a écrit :
> On Mon, May 17, 2021 19:36, Landry Breuil wrote:
> > Le Sun, May 16, 2021 at 08:20:03AM -0400, Josh Grosse a ?crit :
> >> The attached patch updates mapnik from 3.0.10 to 3.1.0.
> >>
> >>   * This resolves the undefined unicode string that broke
> >>     earlier releases of mapnik.
> >>
> >>   * I am unable to figure out how to set the XMLPARSER to
> >>     libxml2 so that OpenStreetMap map files can be parsed
> >>     by mapnik-render.  I've tried setting it in MODSCONS_FLAGS,
> >>     and in this patch set it is currently set in MODSCONS_ENV.
> >>     The XML parsing issue is described at:
> >
> > Fwiw setting XMLPARSER=libxml2 in MODSCONS_FLAGS seems to work here, at
> > least that's what ends up in the generated config.py. Dunno if support
> > for osm files works at runtime though.
> >
> > pretty sure MODGCC4_ARCHS can go :) not sure about py2 by default too..
> >
> > im looking a bit at this update, seems proj>6 support is not there yet
> > (cf https://github.com/mapnik/mapnik/issues/4036) but i wont block the
> > fix for that :D
> >
> > as for SHARED_LIBS bump im unsure a minor is enough.. will do a bit more
> > tests, thanks for that work !
> >
> > Landry
> >
> >
> 
> Hi!
> Attached is a diff based on what I've send Landry about a year ago.

i probably totally forgot about it or lost track.. sorry

> I've added XMLPARSER=libxml2 to MODSCONS_FLAGS and regen WANTLIB.
> From some point upstream doesn't ship data for tests. It could be
> fetched as a separate tarball from github using GH_* variables since
> no archives are present in assets. It would be easier to host them
> ourselves and use MASTER_SITES0 probably.
> Fetching test data as zip archive and extracting it to WRKBUILD before
> running 'make regress' works for me (except tests which needs PROJ):
> test cases:    64 |    61 passed | 3 failed
> assertions: 21422 | 21418 passed | 4 failed
> Most of visual tests are requiring PROJ so they fail too.
> No other test were run except automatic ones.
> It also looks like that mapnik does not require python. All python bindings
> were moved to separate package long time ago. So we can get one less
> python2 consumer.
> Comments?

if it works for you, sure okay. Just put a comment somewhere in the
makefile to reenable proj support in the next update .. also, if you or
Josh want to take maintainership, dont hesitate ! I dont use it.

Landry

Reply via email to