On 2021/06/07 09:25, Martin Ziemer wrote:
> This patch updates remind from 3.3.6 to 3.3.7. 
> 
> Tested on three amd64 systems (One cli only, the other two with
> tkremind)

committed,

> make test fails as root, as root tests are disabled in upstream!
> Using privilege separation in ports means also success for the test.

I think failing in that case is absolutely ok.

I advise against having root anywhere near ports building/tests unless
absolutely necessary (some ports have tests which involve network setup
which requires it).


> If needed i could patch the test to return true, if run as root.
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/misc/remind/Makefile,v
> retrieving revision 1.45
> diff -u -p -r1.45 Makefile
> --- Makefile  31 Mar 2021 13:38:18 -0000      1.45
> +++ Makefile  11 May 2021 05:08:40 -0000
> @@ -2,8 +2,8 @@
>  
>  COMMENT=     scripting language for reminders, with a Tk front end
>  
> -DISTNAME=    remind-03.03.06
> -PKGNAME=     remind-3.3.6
> +DISTNAME=    remind-03.03.07
> +PKGNAME=     remind-3.3.7
>  
>  CATEGORIES=  misc
>  
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/misc/remind/distinfo,v
> retrieving revision 1.17
> diff -u -p -r1.17 distinfo
> --- distinfo  31 Mar 2021 13:38:18 -0000      1.17
> +++ distinfo  11 May 2021 05:08:40 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (remind-03.03.06.tar.gz) = 
> lpoMAXDJxwODY0/aoo25GRBYWFhE4uf11pR5/ITZX1s=
> -SIZE (remind-03.03.06.tar.gz) = 404282
> +SHA256 (remind-03.03.07.tar.gz) = 
> h8lOKdHhiVT/XSIkfX7KMHzmIeEdIsFCCPkD9oo7ij0=
> +SIZE (remind-03.03.07.tar.gz) = 404576
> 

Reply via email to