On Sat, Jun 19, 2021 at 10:30:15AM +0200, Sebastien Marie wrote: > Hi, > > With rustc 1.53, rust has stabilized integer::BITS and it makes the > lexical-core crate vendored in suricata to fail to build with rustc > 1.53.0. > > The following diff backport lexical-core fix which is landed in > lexical-core 0.7.5 (suricata is using 0.6.7). > > Upstream discussion: > https://forum.suricata.io/t/latest-suricata-6-0-2-with-rustc-has-trouble-installing-with-error-could-not-compile-lexical-core/1461 > > The diff is ugly, mostly due to cargo-checksum.json change. but I > think it is preferable to have a diff instead of a post-patch sed > command as the sed command might be easily forgotten on update. > > I tested the build with lang/rust 1.53.0.
I tested the build with both lang/rust 1.53.0 and 1.52.1. > Comments or OK ? The backport looks good to me. The only thing I noticed is that 'make update-patches' complains: *** Patch for rust/vendor/lexical-core/.cargo-checksum.json misses newline at end of file with that fixed, ok tb
