On Sat, Jul 24 2021, Charlene Wendling <juliana...@posteo.jp> wrote:
> Hi,
>
> Decoding using the -lf option on powerpc made ish freeze. A looped
> fgetc(3) call never reached EOF, since the return value was stored
> as a char, that is unsigned on powerpc and arm*, instead of int.
>
> --8<--
> $ cd /tmp && cp /bin/ls .
> $ ish -ss ls
> $ rm ls
> $ ish -lf ls.ish
> [...]
> < Restore from ls.ish >
> <<< ls for UNIX ( use shift_jis ) 2021/07/24 11:55:40 357460 byte >>>
> ls :  Error!! File delete.
> <<< ls for UNIX ( use shift_jis ) 2021/07/24 11:55:40 357460 byte >>>
> ls :
> ooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo
> Finished.
> [infinite loop]
> -->8--
>
> With the below diff, ish properly quits once the decoding has been
> done, and the decoded ls works. Tested on amd64 and macppc.
>
> OK?

Sure, ok

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to