On 2021/08/10 08:36, Laurence Tratt wrote:
> On Tue, Aug 10, 2021 at 05:37:22AM +0000, Yifei Zhan wrote:
> 
> Hello Yifei,
> 
> > This is an update for ffmpeg-nomalize from 1.20.0 to 1.22.1.
> 
> This mostly looks good except:
> 
> > I also added a missing TESTDEP.
> > +
> > +TEST_DEPENDS =             devel/py3-test
> 
> There is no such dependency (though there is a package of that name!) and so
> "make test" immediately fails. I guess you meant:
> 
>   TEST_DEPENDS = devel/py-test${MODPY_FLAVOR}
> 
> It then looks like the way the tests are run has changed and we now need to
> change do-test to something like:
> 
>   do-test:
>       cd ${WRKSRC} && py.test test/test.py
> 
> The tests all seem to work!
> 
> 
> Laurie
> 

If MODPY_PYTEST=Yes works then that would be better. (That automatically
adds the dependency and sets a default test command).

Reply via email to