On Thu, Dec 02, 2021 at 01:07:00AM +0100, Jeremie Courreges-Anglas wrote: > On Thu, Dec 02 2021, Jonathan Gray <j...@jsg.id.au> wrote: > > On Thu, Dec 02, 2021 at 12:12:52AM +0100, Jeremie Courreges-Anglas wrote: > >> On Sun, Nov 28 2021, Christian Weisgerber <na...@mips.inka.de> wrote: > >> > I ran another amd64 bulk build with base clang updated to LLVM 13. > >> > I also put in a tentative fix for security/nss. > >> > > >> > Failure logs: > >> > http://build-failures.rhaalovely.net/amd64-clang/2021-11-27/ > >> > >> [...] > >> > >> > graphics/vulkan-validation-layers -Werror,-Wdeprecated-copy > >> > >> > >> Here's a simple diff that lets this build with llvm13. ok? > > > > I'm ok with this or the recent upstream change > > > > https://github.com/KhronosGroup/Vulkan-ValidationLayers/commit/b38a667579ef66b823bfe33d295ca89384d8fa0d.patch > > Cool to know that the warnings have been fixed. I'm ok with a backport > of this patch but I doubt it would change anything at runtime. And I'd > still like to kill this use of -Werror.
I am too short on time this week to test myself, but both solutions look good to me, so I would say go ahead if you want to get this committed this week. > > >> > >> > >> Index: Makefile > >> =================================================================== > >> RCS file: /cvs/ports/graphics/vulkan-validation-layers/Makefile,v > >> retrieving revision 1.9 > >> diff -u -p -r1.9 Makefile > >> --- Makefile 16 Oct 2021 14:50:41 -0000 1.9 > >> +++ Makefile 1 Dec 2021 23:11:01 -0000 > >> @@ -33,7 +33,8 @@ BUILD_DEPENDS = graphics/glslang \ > >> CONFIGURE_ARGS += -DGLSLANG_INSTALL_DIR="${LOCALBASE}" \ > >> -DBUILD_WSI_WAYLAND_SUPPORT=False \ > >> -DSPIRV_HEADERS_INSTALL_DIR=${LOCALBASE}/include/spirv \ > >> - -DUSE_ROBIN_HOOD_HASHING=False > >> + -DUSE_ROBIN_HOOD_HASHING=False \ > >> + -DBUILD_WERROR=False > >> > >> # Tests only build if Google Test framework is in directory external/ > >> NO_TEST = Yes > >> > >> -- > >> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE > >> > >> > > > > -- > jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE