On Sun, Dec 12, 2021 at 11:52:40AM +0000, Stuart Henderson wrote: > Related to the "policy for dlopen'd libraries etc" mail I just posted but > worth a separate thread I think .. > > When you see "LIB_DEPENDS <xx> not needed for <yy>" when "make package" > runs, it means that the LIB_DEPENDS entry is *ignored* as a run dependency > and is equivalent to BUILD_DEPENDS. > > : LIB_DEPENDS <spec> not needed for <FULLPKGPATH> There doesn't seem to > be > : any WANTLIB to match the given LIB_DEPENDS. Thus, the LIB_DEPENDS won't > : turn into a @depends line in the created package. > > This is nearly always an error - bsd.port.mk(5) lists some "might be > intentional" but those cases are rare and could be handled with conditionals > instead (perhaps it would be better if we do turn it into an actual error). > > I think all current cases in ports *are* an error: > > audio/moc LIB_DEPENDS devel/gettext,-runtime not needed for > audio/moc ? > audio/cantata LIB_DEPENDS audio/libebur128 not needed for > audio/cantata ? > x11/kde-applications/kcron LIB_DEPENDS devel/kf5/kiconthemes not needed > for x11/kde-applications/kcron ? > x11/pidgin-libnotify LIB_DEPENDS net/pidgin,-libpurple not needed for > x11/pidgin-libnotify ? > graphics/opencsg LIB_DEPENDS x11/qt5/qtbase,-main not needed for > graphics/opencsg ? > graphics/piglit LIB_DEPENDS graphics/vulkan-loader not needed > for graphics/piglit ? > net/pidgin LIB_DEPENDS lang/python/3.9 not needed for > net/pidgin,-finch ? > editors/calligra LIB_DEPENDS devel/kf5/kcalendarcore not needed for > editors/calligra ? > editors/calligra LIB_DEPENDS devel/kf5/kcontacts not needed for > editors/calligra ? > editors/calligra LIB_DEPENDS textproc/libwpd not needed for > editors/calligra ? > games/f1spirit LIB_DEPENDS devel/libidn not needed for > games/f1spirit ? > math/nonogram LIB_DEPENDS math/nonolib not needed for math/nonogram ? > sysutils/libfsapfs LIB_DEPENDS sysutils/libfwnt not needed for > sysutils/libfsapfs ? > > > Considering how few there are left, I concur.
Once they're fixed, we can turn these into errors.
