Hi Stuart,

* Stuart Henderson wrote:
> On 2021/12/29 18:11, Matthias Schmidt wrote:
> > attached is a tarball for a new port.  I noticed one strange thing
> > during the port's creation.  make fetch doesn't download the tarball
> > from github although I use the same syntax as other ports and the
> > Makefile template.  The download path is different from the one on the
> > website...  Once I downloaded the tarball to the distfiles, I could
> > easily create the port.
> 
> No idea what's up with your fetch (showing what haopens would help) but
> it works for me.

When I remove the distfile and run make fetch again, I get a size mismatch
although the size should be correct.

$ doas rm /usr/ports/distfiles/jrnlc-2021.b.tar.gz
$ make fetch
===>  Checking files for jrnlc-2021.b
>> Fetch https://github.com/thexhr/jrnlc/archive/2021.b/jrnlc-2021.b.tar.gz
>> Size does not match for jrnlc-2021.b.tar.gz
>> Fetch https://ftp.openbsd.org/pub/OpenBSD/distfiles/jrnlc-2021.b.tar.gz
>> Size does not match for jrnlc-2021.b.tar.gz
[...]

When I now fetch the file from the URL above by hand and rerun make makesum
I get the same distinfo as before.

$ ftp https://github.com/thexhr/jrnlc/archive/2021.b/jrnlc-2021.b.tar.gz
Trying 140.82.121.4...
Requesting https://github.com/thexhr/jrnlc/archive/2021.b/jrnlc-2021.b.tar.gz
Redirected to https://codeload.github.com/thexhr/jrnlc/tar.gz/2021.b
Trying 140.82.121.10...
Requesting https://codeload.github.com/thexhr/jrnlc/tar.gz/2021.b
14729 bytes received in 0.01 seconds (828.97 KB/s)

I now move the tarball to distfiles, rerun make makesum and then compare the
 orginal distinfo and the save copy, they're the same.

$ doas mv jrnlc-2021.b.tar.gz /usr/ports/distfiles/
$ mv distinfo distinfo.old
$ rm distinfo
$ make makesum
===>  Checking files for jrnlc-2021.b
`/usr/ports/distfiles/jrnlc-2021.b.tar.gz' is up to date.
$ diff -u distinfo distinfo.old
$

I like to understand where the error is coming from...

> WANTLIB needs uodating and there are whitespace nits, here's an updated
> Makefile.

Thanks, attached is a new tarball with your Makefile.

Cheers

        Matthias

Reply via email to