Here is revised patch:
i) Update to 1.280, thank upstream.
ii) Keep the previous comments
iii) Update DEPENDS
wen
________________________________________
发件人: Andrew Hewus Fresh <and...@afresh1.com>
发送时间: 2022年1月11日 10:47
收件人: Alexander Bluhm
抄送: wen heping; ports@openbsd.org
主题: Re: www/p5-CGI-Simple: Update to 1.26
On Tue, Jan 11, 2022 at 12:44:30AM +0100, Alexander Bluhm wrote:
> On Tue, Jan 04, 2022 at 08:32:50AM +0000, Stuart Henderson wrote:
> > > MODULES = cpan
> > > PKG_ARCH = *
> > > -DISTNAME = CGI-Simple-1.115
> > > +DISTNAME = CGI-Simple-1.26
> >
> > this results in the version number (as understood by ports) going
> > backwards so will need an EPOCH bump
>
> Some Perl modules have crazy ideas about version numbers. Instead
> of increasing EPOCH each time something stupid happens, some 0 can
> be inserted into package name. This makes it more likely that the
> numbers increase monotonically.
Unfortunately I have to share this regularly at work too.
https://xdg.me/version-numbers-should-be-boring/
> Look at http://matrix.cpantesters.org/?dist=CGI-Simple "Other
> versions" how they jump around.
>
> I think p5-CGI-Simple-1.260 package name should be used in this
> case.
That is how perl thinks of the version internally, not sure if there's a
way to handle that automatically in the ports system though as perl will
think of `v1.26` as `1.026`. That leading "v" is significant. The fact
that perl "5.32" and "v5.32" are the same, but a module's "1.26" and
"v1.26" are not is quite annoying.
> wen heping: Please speak with upstream and try to convince them to
> use continous three digit version numbers like 1.270 in the future.
> It is not only the OpenBSD package manager which has trouble with
> inconsistent numbers.
That above page might help convince them to switch to something better.
I know MANWAR has a fair number of dists so convincing him would
probably help a lot.
Index: Makefile
===================================================================
RCS file: /cvs/ports/www/p5-CGI-Simple/Makefile,v
retrieving revision 1.23
diff -u -p -r1.23 Makefile
--- Makefile 3 Jul 2020 21:45:56 -0000 1.23
+++ Makefile 12 Jan 2022 12:04:20 -0000
@@ -4,14 +4,14 @@ COMMENT = drop-in object-oriented CGI.pm
MODULES = cpan
PKG_ARCH = *
-DISTNAME = CGI-Simple-1.115
+DISTNAME = CGI-Simple-1.280
CATEGORIES = www
-REVISION = 0
# Perl
PERMIT_PACKAGE = Yes
-RUN_DEPENDS = devel/p5-IO-stringy
-TEST_DEPENDS = www/p5-libwww
+TEST_DEPENDS = devel/p5-Test-Exception \
+ devel/p5-Test-NoWarnings \
+ www/p5-libwww
.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/www/p5-CGI-Simple/distinfo,v
retrieving revision 1.12
diff -u -p -r1.12 distinfo
--- distinfo 26 Nov 2015 14:07:31 -0000 1.12
+++ distinfo 12 Jan 2022 12:04:20 -0000
@@ -1,2 +1,2 @@
-SHA256 (CGI-Simple-1.115.tar.gz) = T4c7ydBVr7eyE2hLW8ItMFpFb0PGUTd9PySXF2pYfto=
-SIZE (CGI-Simple-1.115.tar.gz) = 85165
+SHA256 (CGI-Simple-1.280.tar.gz) = GOAen/uBTl5O6neshImyBp/oNlGFUPN/bCIT61Wcar8=
+SIZE (CGI-Simple-1.280.tar.gz) = 86718
