On Fri, Mar 11, 2022 at 01:02:04AM +0100, Alexander Bluhm wrote:
> Hi,
>
> Can we commit espie@'s diff to fix the -Wcompound-token-split-by-macro
> compiler warnings? It reduces the size of my logfiles a lot and
> allows to look at the build output of XS Perl ports.
I'm not opposed, but defer to sthen@ on whether any bumping needs to
happen and therefore if it's better to one-off it in the offenders with
a patch file.
The only other thing is that I wish it would compare
`perl ppport.h --version` to
`perl -MDevel::PPPort -E 'say Devel::PPPort->VERSION'`
and only update if ours is newer, since I don't watch that closely.
I suppose it's fairly unlikely that it will invisibly break something
though.
With those things considered,
OK afresh1@
> bluhm
>
> Index: infrastructure/mk/perl.port.mk
> ===================================================================
> RCS file: /cvs/ports/infrastructure/mk/perl.port.mk,v
> retrieving revision 1.32
> diff -u -p -r1.32 perl.port.mk
> --- infrastructure/mk/perl.port.mk 12 Dec 2021 19:25:39 -0000 1.32
> +++ infrastructure/mk/perl.port.mk 10 Mar 2022 09:04:18 -0000
> @@ -56,6 +56,11 @@ MODPERL_pre-configure = for f in ${MODPE
> ${MODPERL_BIN_ADJ} ${WRKSRC}/$${f}; done
> .endif
>
> +MODPERL_gen = cd ${WRKDIST} && \
> + if test -f ppport.h; then \
> + perl -MDevel::PPPort -e'Devel::PPPort::WriteFile'; \
> + fi
> +
> .if ${CONFIGURE_STYLE:L:Mmodbuild}
> MODPERL_configure = \
> cd ${WRKSRC}; ${SETENV} ${CONFIGURE_ENV} \
