On Fri Mar 11, 2022 at 10:10:42AM +0100, Landry Breuil wrote: > Le Fri, Mar 11, 2022 at 08:54:01AM +0100, Rafael Sadowski a écrit : > > On Wed Mar 09, 2022 at 04:25:15PM +0000, Stuart Henderson wrote: > > > On 2022/03/09 11:15, Rafael Sadowski wrote: > > > > With the results from Stuart's bulk build and Klemens analyses, I end up > > > > with a new diff. > > > > > > > > - Handle target names like libXXX with PREFIX set to "". > > > > With this, all reported errors are happy. Afterwards, we can > > > > delete > > > > all patches. For example, I can remove all x11/kde-application > > > > cmake > > > > hackish patches. > > > > - Use cmSystemTools::GetEnv instead getenv(3) > > > > - More shorter C++ code > > > > > > Makes sense. > > > > > > > Thank you to all. A final bulk build would be advisable, wouldn't it? > > > > > > Definitely needed. I can't run one right now though. > > > > > > > Before Stuart says that net/bro is still broken. I think all cmake ports > > should be ok with the latest patch but not net/bro. Bro calls cmake > > separately and therefore has no access to the environment variables. > > > > I would like to solve this via an option MODCMAKE_USE_SAHRED_LIBS.(Other > > name proposals?) This way we can also deactivate in the future if we > > have to. > > i think you meant MODCMAKE_USE_SHARED_LIBS ;) >
With a rsadowski-typo it would be unique, but that's okay too ;-).Thanks for the review.
