On 2022/05/04 12:30, portno12 wrote:
> got it.
> 
> new tarball with your previous diff and the tests i ignored removed. i left 
> the link for documentation of the failing tests.
> 
> any other changes you can see that i might need to make and learn from?

I don't think so, this is OK with me (ifor reviewers: the other port
needed is in https://marc.info/?l=openbsd-ports&m=165159894521779&w=2)

> 
> ------- Original Message -------
> On Wednesday, May 4th, 2022 at 12:23 PM, Stuart Henderson 
> <s...@spacehopper.org> wrote:
> 
> 
> > On 2022/05/04 12:07, portno12 wrote:
> >
> > > thanks for the help with the missing port and diff.
> > >
> > > adding your diff and the missing port got this further. there were a 
> > > number of tests still failing. i ignored the broken tests as its a known 
> > > issue (https://github.com/gabrielfalcao/HTTPretty/issues/449), i also 
> > > added py-requests as a needed test dep.
> > >
> > > a couple warnings (also known in the same issue above) still present but 
> > > they didnt fail any tests.
> > >
> > > updated tarball attached for py-httpretty.
> >
> >
> > Better to not disable tests which are just failing, unless they prevent
> > other tests from running (as was the case with some of the tests with
> > missing dep's)
> >
> > I don't expect tests to always all pass, in most cases it's more about
> > getting a feel for whether the software in general is going to work ok
> > on OpenBSD
> >
> > > ------- Original Message -------
> > > On Tuesday, May 3rd, 2022 at 5:29 PM, Stuart Henderson 
> > > s...@spacehopper.org wrote:
> > >
> > > > On 2022/05/02 23:55, portno12 wrote:
> > > >
> > > > > created by portgen and seems fine on amd64, no tests due to needing a 
> > > > > lot of new or updated ports. its a dep for another port i am working 
> > > > > on so will get tested via that soon
> > > >
> > > > portgen isn't really good at python ports at the moment.
> > > >
> > > > Here are some changes on top and the 1 new port needed to enable most
> > > > tests.
> > > >
> > > > diff --git www/py-httpretty/Makefile www/py-httpretty/Makefile
> > > > index f29b61f..8d28950 100644
> > > > --- www/py-httpretty/Makefile
> > > > +++ www/py-httpretty/Makefile
> > > > @@ -16,12 +16,22 @@ MODULES = lang/python
> > > >
> > > > MODPY_PI = Yes
> > > > MODPY_SETUPTOOLS = Yes
> > > > -MODPY_TEST = Yes
> > > > -MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}
> > > > +MODPY_PYTEST = Yes
> > > >
> > > > -# many test deps either need ported or updated
> > > > -NO_TEST = Yes
> > > > +# need https, eventlet - not ported
> > > > +MODPY_PYTEST_ARGS = --ignore 
> > > > tests/bugfixes/nosetests/test_414_httpx.py \
> > > > + --ignore tests/bugfixes/nosetests/test_eventlet.py \
> > > > + --ignore tests/functional/test_httplib2.py
> > > > +
> > > > +FLAVOR = python3
> > > > +FLAVORS = python3
> > > > +
> > > > +TEST_DEPENDS = devel/py-freezegun${MODPY_FLAVOR} \
> > > > + devel/py-sure${MODPY_FLAVOR} \
> > > > + net/py-boto3${MODPY_FLAVOR} \
> > > > + www/py-httplib2${MODPY_FLAVOR} \
> > > > + www/py-tornado${MODPY_FLAVOR}
> > > >
> > > > -# Lines below not in the template
> > > > FIX_EXTRACT_PERMISSIONS = Yes
> > > > +
> > > > .include <bsd.port.mk>
> >
> >


Reply via email to