Mikhail <mp39...@gmail.com> wrote:
> On Mon, Jun 06, 2022 at 10:39:52AM +0100, Stuart Henderson wrote:
> > On 2022/06/06 11:12, Omar Polo wrote:
> > > some tweaks are needed:
> >
> > I agree with all your tweaks. Generally ok to import (as long as
> > MAINTAINER really is correct). The pledge/unveil stuff mentioned in
> > README does not really nice though, this is not something users should
> > have to fiddle with for basic operation, I would drop that section from
> > the readme and leave it for advanced users to find for themselves if
> > they want to be responsible for keeping it up to date/fixing things.
>
> I've applied tweaks from Omar, added epicrc.sample to files/ and install
> it to ${PREFIX}/share/epic5/script instead of embedding in README, also
> removed pledge/unveil example from this file as Stuart suggested, left
> only a note, that further information about the syscalls usage is in
> UPDATES document.
I think that now it's perfect :)
> Regarding maintainer - Joey will be the "official" one, so the variable
> is set correctly, but we both will take care of this port.
if you want you can also add more than one person in the MAINTAINER
line; it's not extremely common but not so rare either to have more than
one maintainer per package (see for example net/tdesktop, it's the first
one that comes to mind.) not saying you must, it's just an option in
case you didn't know.
I'd wait a confirmation from Joey thought, as far as i can see they
haven't posted anything to this thread yet.
> Appreciated for the review.
Cheers,
Omar Polo
