Yifei Zhan <openbsd@zhan.science> wrote: > On 22/06/12 10:43AM, mazzurco.riccardo wrote: > > Hi, > > I attached a new port for Pixelorama - > > https://orama-interactive.itch.io/pixelorama > > From the DESCR: > > > > Looks interesting to me :) > > A few tweaks: > > - The built in .desktop file sets Icon=icon.png, this won't work > because that file doesn't exist. I tweaked Makefile to fetch the > icon file from the upstream repo and install it before setting up > .desktop file: > > MASTER_SITES = > https://github.com/Orama-Interactive/Pixelorama/releases/download/v$V/ > MASTER_SITES0 = > https://github.com/Orama-Interactive/Pixelorama/raw/v$V/Misc/Clickable/click/ > DISTFILES = ${DISTNAME}{Pixelorama.Linux-64bit}${EXTRACT_SUFX} \ > icon.png:0 > > > EXTRACT_ONLY = ${DISTNAME}${EXTRACT_SUFX}
There's a minor issue in doing this: `icon.png' is a generic name and
furthermore, since doesn't take into account the version, it's
impossible to update it for future release. (to verify: try setting V
to 0.10 and re-run make-makesum, it'll tell you that icon.png is
'already up-to-date' but will re-fetch the tarball)
I've changed it to `pixelorama-$V{icon}.png'
> ---cut---
>
> ${INSTALL_DATA_DIR} ${PREFIX}/share/pixmaps/
> ${INSTALL_DATA} ${FULLDISTDIR}/icon.png
> ${PREFIX}/share/pixmaps/pixelorama.png
> ${SUBST_DATA} ${FILESDIR}/pixelorama.desktop \
> ${PREFIX}/share/applications/pixelorama.desktop
>
> - .desktop file is modified to use the correct path:
>
> Icon=${TRUEPREFIX}/share/pixmaps/pixelorama.png
nitpick: we can avoid running SUBST_DATA on the desktop file. Icon can
be set to `pixelorama' alone and it works. (many other desktop files do
this, probably to allow the user to change the theme of the icons)
> - This port is tested on amd64 (the only supported arch, as this port
> uses pre-compiled file), works fine for me.
Thanks for testing! The idea would be to eventually add a third
subpackage to games/godot to build stuff like this directly from the
port tree avoiding having to fetch pck files or installing all the
sources as sysutils/appmanager does. (godot wants an X11 connection to
even export a project as pck unless compiled without the GUI on.)
(a pck file is not really "precompiled" really, AFAIK is just a bundle
of the gdscript code plus the game assets. I don't really know how
cross-architecture they are thought.)
> - Formatting change for consistency.
this is the only point where I don't really agree :P
Unless the file is atrociously or inconsistently indented, I guess we
can leave what the author prefers. TBF I don't like to have the values
indented that much either, but we have already several ports that use
that style and let's leave the choice to the maintainer.
The tabs after between the commands and their argument in do-install
instead are something new to me, and I don't really like that either ^^"
it's just a matter of preference/style.
Attaching a slightly edited tarball with the above points addressed
that's OK for me to import (full disclaimer: I worked with Riccardo on
this port.)
(I've also slightly tweaked the INSTALL_DATA_DIR to take advantage of
the brace expansion done by the shell)
pixelorama.tar.gz
Description: GNU Zip compressed data
