Thim Cederlund <t...@cederlund.de> wrote: > Hi, > > On 24/06-22 09:13, Omar Polo wrote: > > looks fine and works fine as usual, thanks! :) > > > > However, I noticed a few things that we may want to consider for the > > update. First of all, the development has moved to codeberg after > > github wiped (but then restored) the account of the maintainer[0]. > > Moving from GH_* to a custom MASTERSITE for Codeberg probably isn't an > > option, but they also have added an homepage[1] that we may want to link. > > Secondarly, I've noticed that upstream do provide icons for the > > software, so why don't install them as well? > > > > [0]: > > https://nrk.neocities.org/articles/miserable-state-of-github-moderation.html > > [1]: https://nsxiv.codeberg.page/ > > > > Updated diff with these addressed and the patch regenerated (make > > update-patches). It's ok for you? :) > > Sure, adding the MASTRERSITE codeberg is ok by me. > > I agree with your changes and not adding the icons was a clear miss > from my end. I don't use icons so I didn't even notice there were > any.
they're also difficult to discover, i noticed an `install-icons' almost by chance when I was taking a quick look at the homepage... Committed, thanks! > Thank you Omar :) > > > > > Cheers, > > > > Omar Polo