On 2022/08/26 13:18, Aaron Bieber wrote:
> Here is the companion tool to step-ca.
>
> It can be used to create X.509 certs, request certs from an ACME server,
> JWT...
> things.. and a number of other tasks!
>
> OK to import?
I still think the binary should not be renamed, either leave it to conflict
with kde-applications/step (since I don't think many people will run KDE
software _and_ this), or since KDE step would normally be run from a desktop
environment we could rename it there and adjust the .desktop file and
probably no users would notice any difference as they probably don't
even type the name..(diff for that below)
As a cli tool, the short name matching the doco seems to make much more
sense to me. (I am totally happy with the step-cli package name which
is pretty standard across OS). And that matches what freebsd, nix and
alpine do.
OTOH arch does rename it so if you *really* want to then I'll grudgingly
ok that too, at least we wouldn't be the only one doing it.
I see there are some bash/zsh completions files which I think would make
sense to install.
Thoughts? rsadowski?
Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/kde-applications/step/Makefile,v
retrieving revision 1.17
diff -u -p -r1.17 Makefile
--- Makefile 25 Aug 2022 20:13:27 -0000 1.17
+++ Makefile 12 Sep 2022 21:21:36 -0000
@@ -1,6 +1,7 @@
COMMENT = KDE interactive physics simulator
DISTNAME = step-${VERSION}
CATEGORIES = education math
+REVISION = 0
HOMEPAGE = https://www.kde.org/applications/education/step
@@ -42,5 +43,8 @@ LIB_DEPENDS = devel/gsl \
devel/kf5/kxmlgui \
devel/kf5/sonnet \
math/libqalculate
+
+post-install:
+ mv ${PREFIX}/bin/step ${PREFIX}/bin/step-kde
.include <bsd.port.mk>
Index: patches/patch-step_org_kde_step_desktop
===================================================================
RCS file: patches/patch-step_org_kde_step_desktop
diff -N patches/patch-step_org_kde_step_desktop
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-step_org_kde_step_desktop 12 Sep 2022 21:21:36 -0000
@@ -0,0 +1,12 @@
+Index: step/org.kde.step.desktop
+--- step/org.kde.step.desktop.orig
++++ step/org.kde.step.desktop
+@@ -1,7 +1,7 @@
+ # KDE Config File
+ [Desktop Entry]
+ Type=Application
+-Exec=step -qwindowtitle %c -qwindowicon step
++Exec=step-kde -qwindowtitle %c -qwindowicon step
+ Icon=step
+ MimeType=application/x-step;
+ X-DocPath=step/index.html
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/x11/kde-applications/step/pkg/PLIST,v
retrieving revision 1.18
diff -u -p -r1.18 PLIST
--- pkg/PLIST 13 Jul 2022 15:45:42 -0000 1.18
+++ pkg/PLIST 12 Sep 2022 21:21:36 -0000
@@ -1,5 +1,5 @@
@pkgpath x11/kde4/step
-@bin bin/step
+@bin bin/step-kde
share/applications/org.kde.step.desktop
share/config.kcfg/
share/config.kcfg/step.kcfg
