Index: infrastructure/bin/register-plist
===================================================================
RCS file: /cvs/ports/infrastructure/bin/register-plist,v
retrieving revision 1.31
diff -u -p -r1.31 register-plist
--- infrastructure/bin/register-plist   26 May 2022 06:55:06 -0000      1.31
+++ infrastructure/bin/register-plist   4 Oct 2022 14:04:48 -0000
@@ -272,6 +272,9 @@ sub compare_more
        if ($self->{pkgpath} ne $self2->{pkgpath}) {
                return Result::Different;
        }
+       if ($self->{pattern} ne $self2->{pattern}) {
+               return Result::Different;
+       }
 
        return $self->make_result(
            OpenBSD::PackageName->from_string($self->{def})->compare(


Discussed this a bit with sthen@

At face value, pattern changes do not require bumps (pkg_add -u will happily
ignore them), but in many many cases, changes to them mean that something
in the dependency tree got fixed 
(like in the recent gimp/stable <-> gimp/snapshot fuck-up).

So it's much easier to "force the bump" so that people will get up-to-date
packages.

I could also force the bump in pkg_add and make things not comparable, but
it's not needed.


Another possibility would be to have it be Result::UpdatableButShowDiff 
(which will require combining with the next possible return combo, obviously,
in case it is Result::Different).

Unless people strongly object, I'm going to lean towards Result::Different,
which is also help making sure stable packages are rebuilt.

Reply via email to