Theo Buehler:

> x11/chbg              gtk/gnome stuff [-Wint-conversion]

X11 stuff, really.

This code uses gdk_atom_intern() to construct an atom that it passes
to various X*Property() functions.  Except that gdk_atom_intern()
returns a pointer to a GdkAtom structure, which is most certainly
not an X11 Atom.  As is, the code calls X*Property() with what
amounts to random garbage.  Maybe the calls to gdk_atom_intern()
can be replaced with XInternAtom(), but I don't really know anything
about X11 programming.  There is also the slight risk that fixing
nonfunctioning code might end up breaking something.

It appears chbg started in 1999 for GTK1 and was barely moved over
to GTK2.  It was last touched in 2006.  We could just remove the
port; it's gone from FreeBSD and Debian.

Missing from your list:

| x11/eterm             [-Wint-conversion]

That mixes pointer and integer semantics in such a way that I
couldn't figure out what it was even intended to do.

-- 
Christian "naddy" Weisgerber                          na...@mips.inka.de

Reply via email to