Yifei Zhan wrote (2023-02-20 12:37 CET): > ping with patch & tarball reattached :) > > On 23/02/11 03:45AM, Yifei Zhan wrote: > > Hi, > > > > xournalpp (Xournal++) is a handwriting notetaking software with PDF > > annotation > > support. It has good balance in terms of lightweightness and feature and > > has > > been part of my notetaking workflow. > > > > Tested on amd64, audio recording needs extra steps to enable and has been > > documented in README, PDF annotation with text and images also works fine. > > > > This port requires cxx binding to be enabled for audio/portaudio-svn, a > > patch is > > included for that. > > > > Both xournalpp and patched portaudio-svn passed portcheck and > > port-lib-depends-check. Builtin testing is not ported but any help is > > welcomed. > > > > any comments?
Hi Yihey, thanks for porting this. Here are a few comments: for portaudio-svn: Please bump REVISION. Only bumping the shared libaries does not lead to a rebuild. Updated diff below. for xournalpp: You can drop HOMEPAGE for GH_ ports where the Homepage is the github repository. In this case however, there is a real homepage: https://xournalpp.github.io Attached again with the following changes: - set HOMEPAGE to https://xournalpp.github.io - sorted BUILD_DEPENDS, RUN_DEPENDS, LIB_DEPENDS - extract both manpage files with one gzip call - changed CATEGORY to print only In my opinion this port should go into the print category. I agree that both categories fit, but I find it odd to have print/xournal and productivity/xournalpp. With those changes, OK sdk@ Best regards, Stefan Index: audio/portaudio-svn/Makefile =================================================================== RCS file: /cvs/ports/audio/portaudio-svn/Makefile,v retrieving revision 1.22 diff -u -p -u -p -r1.22 Makefile --- audio/portaudio-svn/Makefile 11 Mar 2022 18:20:26 -0000 1.22 +++ audio/portaudio-svn/Makefile 21 Feb 2023 08:19:46 -0000 @@ -2,23 +2,29 @@ COMMENT= portable cross-platform audio DISTNAME = pa_stable_v190700_20210406 PKGNAME = portaudio-svn-1970 +REVISION = 0 + CATEGORIES= audio MASTER_SITES = http://files.portaudio.com/archives/ EXTRACT_SUFX = .tgz -SHARED_LIBS = portaudio 1.2 +SHARED_LIBS += portaudio 1.2 +SHARED_LIBS += portaudiocpp 0.12 HOMEPAGE= http://www.portaudio.com/ # MIT PERMIT_PACKAGE= Yes -WANTLIB= m pthread sndio +WANTLIB += ${COMPILER_LIBCXX} m sndio + +COMPILER = base-clang ports-gcc USE_GMAKE= Yes AUTOCONF_VERSION = 2.69 CONFIGURE_STYLE= autoconf no-autoheader -CONFIGURE_ARGS= --without-alsa --without-oss --without-jack +CONFIGURE_ARGS= --without-alsa --without-oss --without-jack \ + --enable-cxx # builds non-automated, interactive tests in ${WRKBUILD}/bin TEST_TARGET= tests Index: audio/portaudio-svn/pkg/PLIST =================================================================== RCS file: /cvs/ports/audio/portaudio-svn/pkg/PLIST,v retrieving revision 1.5 diff -u -p -u -p -r1.5 PLIST --- audio/portaudio-svn/pkg/PLIST 11 Mar 2022 18:20:27 -0000 1.5 +++ audio/portaudio-svn/pkg/PLIST 21 Feb 2023 08:19:46 -0000 @@ -1,5 +1,29 @@ include/portaudio.h +include/portaudiocpp/ +include/portaudiocpp/AutoSystem.hxx +include/portaudiocpp/BlockingStream.hxx +include/portaudiocpp/CFunCallbackStream.hxx +include/portaudiocpp/CallbackInterface.hxx +include/portaudiocpp/CallbackStream.hxx +include/portaudiocpp/CppFunCallbackStream.hxx +include/portaudiocpp/Device.hxx +include/portaudiocpp/DirectionSpecificStreamParameters.hxx +include/portaudiocpp/Exception.hxx +include/portaudiocpp/HostApi.hxx +include/portaudiocpp/InterfaceCallbackStream.hxx +include/portaudiocpp/MemFunCallbackStream.hxx +include/portaudiocpp/PortAudioCpp.hxx +include/portaudiocpp/SampleDataFormat.hxx +include/portaudiocpp/Stream.hxx +include/portaudiocpp/StreamParameters.hxx +include/portaudiocpp/System.hxx +include/portaudiocpp/SystemDeviceIterator.hxx +include/portaudiocpp/SystemHostApiIterator.hxx @static-lib lib/libportaudio.a lib/libportaudio.la @lib lib/libportaudio.so.${LIBportaudio_VERSION} +@lib lib/libportaudiocpp.so.${LIBportaudiocpp_VERSION} +@static-lib lib/libportaudiocpp.a +lib/libportaudiocpp.la lib/pkgconfig/portaudio-2.0.pc +lib/pkgconfig/portaudiocpp.pc
xournalpp.tgz
Description: application/tar-gz
