On Thu, 02 Mar 2023 07:07:49 +0000, Renato Aguiar wrote:
> I attached a new version addressing comments and updating it to latest
> version.
Build and tests OK on OpenBSD-current/amd64. I have tested your rust-
analyzer port with Neovim and nvim-lsp plugin.
Some comments :
- use MAKE_ENV += CFG_RELEASE=${GH_TAGNAME} (+= instead of a simple =)
- add WANTLIB += ${MODCARGO_WANTLIB} in Makefile
Without it, there are some errors with make port-lib-depends-check :
rust-analyzer-20230227(devel/rust-analyzer-renato):
Missing: c++abi.6 (/usr/local/bin/rust-analyzer) (system lib)
Missing: c.97 (/usr/local/bin/rust-analyzer) (system lib)
Missing: pthread.27 (/usr/local/bin/rust-analyzer) (system lib)
WANTLIB += c c++abi pthread
*** Error 1 in target 'port-lib-depends-check' (ignored)
I have also packaged rust-analyzer for many months but not posted my work
here. You can find it in GH openbsd-wip repository https://github.com/
jasperla/openbsd-wip/tree/master/devel/rust-analyzer
Compared to your port, I have also packaged the user docs for rust-
analyzer :
- patch to concatenate docs/user/manual.adoc and docs/user/
generated_config.adoc files
- convert AsciiDoc manual.adoc file to HTML
- install manual.html in ${PREFIX}/share/doc/rust-analyzer
Could you please merge your port and my work ?
Laurent
