On Thu, Mar 09, 2023 at 12:06:57PM +0000, Stuart Henderson wrote: > On 2023/03/09 07:13, Ali Farzanrad wrote: > > --- Quake/Makefile.orig > > +++ Quake/Makefile > > -@@ -29,7 +29,7 @@ VORBISLIB=vorbis > > - # Helper functions > > - # --------------------------- > > - > > --check_gcc = $(shell if echo | $(CC) $(1) -Werror -S -o /dev/null -xc - > > > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi;) > > -+check_gcc = $(shell if echo | $(CC) $(1) -S -o /dev/null -xc - > > > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi;) > > - > > Please leave in the hunk that removes -Werror
yes, what's the reason for this being in the diff/ > > > > - # --------------------------- > > - > > -@@ -51,7 +51,7 @@ LDFLAGS ?= > > +@@ -51,15 +51,15 @@ LDFLAGS ?= > > DFLAGS ?= > > CFLAGS ?= > > > > -CFLAGS += -Wall -Wno-trigraphs -Wno-unused-function -Werror -std=gnu11 > > -MMD > > +CFLAGS += -Wall -Wno-trigraphs -Wno-unused-function -std=gnu11 -MMD > > CFLAGS += $(CPUFLAGS) > > ++CFLAGS += -DUSE_CRT_MALLOC Can you reference documentation about the option USE_CRT_MALLOC? I can't find any in the vkquake files, nor on a quick web search. > > ifneq ($(DEBUG),0) > > DFLAGS += -D_DEBUG > > -@@ -59,7 +59,6 @@ CFLAGS += -g > > + CFLAGS += -g > > do_strip= > > else > > DFLAGS += -DNDEBUG > >
