While very grateful for the recent updates to the port infrastructure, the
changes to the OpenBSD::ProgressMeter class seem to have broken the
infrstructure/build/out-of-date script. I am aware there are other ways of
doing this now, and after reading through the recent diffs it would seem this
script has probably been broken for some time.
Anyway, I've attached a diff which I think bring the out-of-date script back to
life. It works for me, but my perl skills aren't wonderful, so please feel free
to point out the obvious errors.
David.
Index: infrastructure/build/out-of-date
===================================================================
RCS file: /cvs/ports/infrastructure/build/out-of-date,v
retrieving revision 1.16
diff -u -r1.16 out-of-date
--- infrastructure/build/out-of-date 1 Jun 2007 15:01:50 -0000 1.16
+++ infrastructure/build/out-of-date 15 Jun 2007 10:07:06 -0000
@@ -96,9 +96,9 @@
my $error = {};
my $count = 0;
my $total = scalar @subdirs;
-
- my $progress = OpenBSD::ProgressMeter->new;
- $progress->set_header("Collecting port versions");
+
+ OpenBSD::ProgressMeter::set_header("Collecting port versions");
+
my ($fh, $old) = fh_open($cmd);
my $subdir = "";
while (<$fh>) {
@@ -106,7 +106,7 @@
if (/^\=\=\=\>\s+(\S+)/) {
$subdir = $1;
$count++;
- $progress->show($count, $total);
+ OpenBSD::ProgressMeter::show($count, $total);
next;
}
next unless $_ or $subdir;
@@ -123,7 +123,7 @@
$port->{$subdir}->{version} = $version;
}
fh_close($fh, $old);
- $progress->next;
+ OpenBSD::ProgressMeter::next();
return $port, $error;
}
@@ -154,8 +154,7 @@
my $count = 0;
my $total = scalar @subdirs;
- my $progress = OpenBSD::ProgressMeter->new;
- $progress->set_header("Collecting port signatures");
+ OpenBSD::ProgressMeter::set_header("Collecting port signatures");
my ($fh, $old) = fh_open($cmd);
my $subdir = "";
while (<$fh>) {
@@ -163,14 +162,14 @@
if (/^\=\=\=\>\s+(\S+)/) {
$subdir = $1;
$count++;
- $progress->show($count, $total);
+ OpenBSD::ProgressMeter::show($count, $total);
next;
}
next unless $_ or $subdir;
$port->{$subdir}->{signature} = $_;
}
fh_close($fh, $old);
- $progress->next;
+ OpenBSD::ProgressMeter::next();
}
sub split_sig
