On Sat, Jul 15 2023, Matthieu Herrb <matth...@openbsd.org> wrote: > On Sat, Jul 15, 2023 at 03:06:09PM +0200, Matthieu Herrb wrote: >> Lightweight KMS plane library. >> >> libliftoff eases the use of KMS planes from userspace without standing >> in your way. Users create "virtual planes" called layers, set KMS >> properties on them, and libliftoff will pick hardware planes for these >> layers if possible. >> >> Will be needed by wlroots/sway. >> > > New version wi[th] fixed SHARELD_LIBS and PLIST
Please s/Lightweight/lightweight/ in COMMENT and start SHARED_LIBS at 0.0 (new port). libliftoff.pc mentions a dep on libdrm >= 2.4.108, that's not a problem but it would appear more correct/future-proof to just drop the version (from meson.build). In DESCR I would drop the first paragraph (which just repeats COMMENT). Actually I would just keep the second paragraph. In Makefile, could you please tab-align values in assignements? (No need for perfect alignement, it's just nicer to read.) -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
