On 2023/08/17 09:29:04 -0600, Ashlen <d...@anthes.is> wrote: > On Thu, 17 Aug 2023 10:23 +0200, Omar Polo wrote: > > - typo on SEPARATE_BUILD (should be SEPARATED_BUILD) > > I checked and SEPARATE_BUILD is right. I just rebuilt StyLua with > SEPARATE_BUILD to make sure that it works, so I think it should be > kept, right?
sorry for the brain fart. Indeed the right name is SEPARATE_BUILD (and I'll add SEPARATED_BUILD to my .poison list.) Anyway, it doesn't harm but I do see a very little point in specifiying it, the configure step of the cargo build seems rather quick. > > - missing WANTLIBs > > > > not sure why CONFIGURE_STYLE is needed but the build fails otherwise > > and rust is out of my comfort zone. It also seem to build stuff > > during fake, don't know if it's usual for rust ports. > > I don't write Rust, but there's this in cargo-module(5). > > """ > With CONFIGURE_STYLE set to 'cargo', cargo is configured to use > MODCARGO_VENDOR_DIR instead of the standard crates-io network source. > """ right, this is due my ignorance with the rust/cargo porting. > > It's sad that there's not documentation other than the README.md (that > > isn't much legible with less(1)). stylua -h | less seems like a > > manpage however, meh. > > I agree, a man page would've been nicer. > > Thank you for reviewing this, and apologies for the sloppy work. > Other than wanting to add SEPARATE_BUILD back in, your changes seem > good to me. don't feel strongly about SEPARATE_BUILD but I'd propend to skip it. It's ok op@ to import either way. Thanks!
